Skip to content

fix: use org.junit.jupiter.api.Assertions.assertThrow#12882

Merged
jinseopkim0 merged 1 commit intomainfrom
ci-fix
Apr 21, 2026
Merged

fix: use org.junit.jupiter.api.Assertions.assertThrow#12882
jinseopkim0 merged 1 commit intomainfrom
ci-fix

Conversation

@jinseopkim0
Copy link
Copy Markdown
Contributor

@jinseopkim0 jinseopkim0 commented Apr 21, 2026

Fixes sdk-platform-java / sdk-platform-java integration tests. E.g. https://github.com/googleapis/google-cloud-java/actions/runs/24742154835/job/72384559891?pr=12844

@jinseopkim0 jinseopkim0 marked this pull request as ready for review April 21, 2026 20:38
@jinseopkim0 jinseopkim0 requested a review from a team as a code owner April 21, 2026 20:38
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ChannelPoolTest class to use JUnit Jupiter's assertThrows method instead of the JUnit 4 version. I have no feedback to provide as there were no review comments to evaluate.

@sonarqubecloud
Copy link
Copy Markdown

@sonarqubecloud
Copy link
Copy Markdown

@jinseopkim0 jinseopkim0 enabled auto-merge (squash) April 21, 2026 21:10
@jinseopkim0 jinseopkim0 merged commit bf243a6 into main Apr 21, 2026
141 of 147 checks passed
@jinseopkim0 jinseopkim0 deleted the ci-fix branch April 21, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants