test(bigquery): Add tests to verify lossless max timestamp parsing#12892
Merged
jinseopkim0 merged 8 commits intomainfrom Apr 22, 2026
Merged
test(bigquery): Add tests to verify lossless max timestamp parsing#12892jinseopkim0 merged 8 commits intomainfrom
jinseopkim0 merged 8 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces unit and integration tests to verify the lossless handling of maximum timestamps when the useInt64Timestamps flag is enabled. The feedback focuses on improving the integration test by ensuring consistent method visibility, optimizing resource usage by reusing existing BigQuery options, and adding an assertion to verify that the query result set is not empty before validation.
…loud/bigquery/it/ITBigQueryTest.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…loud/bigquery/it/ITBigQueryTest.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…loud/bigquery/it/ITBigQueryTest.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
lqiu96
reviewed
Apr 22, 2026
lqiu96
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/326260769