fix(bqjdbc): enhance logging with caller inference and explicit exception tracking#12903
Merged
fix(bqjdbc): enhance logging with caller inference and explicit exception tracking#12903
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves error visibility across the BigQuery JDBC driver by introducing explicit logging in several catch blocks and enhancing the BigQueryJdbcCustomLogger to support caller inference and exception stack trace formatting. A new test class was also added to verify the logger's functionality. Review feedback suggests correcting a typo in the .gitignore file, optimizing the logger's caller inference, and refactoring the exception logging to use LogRecord for better integration with structured logging systems.
logachev
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/505727302
Note: More catch block instrumentation to follow in future PRs.