-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: Update Saas Service Management README to reference App Lifecycle Manager #12942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+12
−12
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||
| # Google SaaS Runtime API Client for Java | ||||||
| # Google App Lifecycle Manager Client for Java | ||||||
|
|
||||||
| Java idiomatic client for [SaaS Runtime API][product-docs]. | ||||||
| Java idiomatic client for [App Lifecycle Manager][product-docs]. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
|
|
||||||
| [![Maven][maven-version-image]][maven-version-link] | ||||||
| ![Stability][stability-image] | ||||||
|
|
@@ -67,14 +67,14 @@ See the [Authentication][authentication] section in the base directory's README. | |||||
|
|
||||||
| ## Authorization | ||||||
|
|
||||||
| The client application making API calls must be granted [authorization scopes][auth-scopes] required for the desired SaaS Runtime API APIs, and the authenticated principal must have the [IAM role(s)][predefined-iam-roles] required to access GCP resources using the SaaS Runtime API API calls. | ||||||
| The client application making API calls must be granted [authorization scopes][auth-scopes] required for the desired App Lifecycle Manager APIs, and the authenticated principal must have the [IAM role(s)][predefined-iam-roles] required to access GCP resources using the App Lifecycle Manager API calls. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider using the singular "API" instead of "APIs" for consistency with the usage on line 76 and to better reflect the service name.
Suggested change
|
||||||
|
|
||||||
| ## Getting Started | ||||||
|
|
||||||
| ### Prerequisites | ||||||
|
|
||||||
| You will need a [Google Cloud Platform Console][developer-console] project with the SaaS Runtime API [API enabled][enable-api]. | ||||||
| You will need to [enable billing][enable-billing] to use Google SaaS Runtime API. | ||||||
| You will need a [Google Cloud Platform Console][developer-console] project with the App Lifecycle Manager [API enabled][enable-api]. | ||||||
| You will need to [enable billing][enable-billing] to use Google App Lifecycle Manager. | ||||||
| [Follow these instructions][create-project] to get your project set up. You will also need to set up the local development environment by | ||||||
| [installing the Google Cloud Command Line Interface][cloud-cli] and running the following commands in command line: | ||||||
| `gcloud auth login` and `gcloud config set project [YOUR PROJECT ID]`. | ||||||
|
|
@@ -84,13 +84,13 @@ You will need to [enable billing][enable-billing] to use Google SaaS Runtime API | |||||
| You'll need to obtain the `google-cloud-saasservicemgmt` library. See the [Quickstart](#quickstart) section | ||||||
| to add `google-cloud-saasservicemgmt` as a dependency in your code. | ||||||
|
|
||||||
| ## About SaaS Runtime API | ||||||
| ## About App Lifecycle Manager | ||||||
|
|
||||||
|
|
||||||
| [SaaS Runtime API][product-docs] Model, deploy, and operate your SaaS at scale. | ||||||
| [App Lifecycle Manager][product-docs] Model, deploy, and operate your SaaS at scale. | ||||||
|
|
||||||
| See the [SaaS Runtime API client library docs][javadocs] to learn how to | ||||||
| use this SaaS Runtime API Client Library. | ||||||
| See the [App Lifecycle Manager client library docs][javadocs] to learn how to | ||||||
| use this App Lifecycle Manager Client Library. | ||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
@@ -103,7 +103,7 @@ To get help, follow the instructions in the [shared Troubleshooting document][tr | |||||
|
|
||||||
| ## Transport | ||||||
|
|
||||||
| SaaS Runtime API uses both gRPC and HTTP/JSON for the transport layer. | ||||||
| App Lifecycle Manager uses both gRPC and HTTP/JSON for the transport layer. | ||||||
|
|
||||||
| ## Supported Java Versions | ||||||
|
|
||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is generated from name_pretty in generation_config.yaml. Updating the config should trigger regeneration of this file and the README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see. repo-metadata is probably generated then