Skip to content

fix(bqjdbc): metadata methods & getSqlTypeName for struct #12947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
logachev merged 3 commits into from
May 4, 2026
Merged

fix(bqjdbc): metadata methods & getSqlTypeName for struct #12947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0fdf6c
fix(bqjdbc): metadata methods & getSqlTypeName for struct
logachev Apr 29, 2026
2638cd4
unittest & feedback
logachev Apr 29, 2026
22d8c61
lint
logachev Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...-cloud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryBaseStruct.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

import com.google.cloud.bigquery.Field;
import com.google.cloud.bigquery.FieldList;
import com.google.cloud.bigquery.StandardSQLTypeName;
import com.google.cloud.bigquery.exception.BigQueryJdbcSqlFeatureNotSupportedException;
import java.sql.Date;
import java.sql.SQLException;
Expand All @@ -42,7 +43,7 @@ abstract class BigQueryBaseStruct implements java.sql.Struct {

@Override
public final String getSQLTypeName() throws SQLException {
throw new BigQueryJdbcSqlFeatureNotSupportedException(CUSTOMER_TYPE_MAPPING_NOT_SUPPORTED);
return StandardSQLTypeName.STRUCT.name();
}

@Override
Expand Down
12 changes: 6 additions & 6 deletions ...-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryDatabaseMetaData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,27 +515,27 @@ public boolean supportsSchemasInPrivilegeDefinitions() {

@Override
public boolean supportsCatalogsInDataManipulation() {
return false;
return true;
}

@Override
public boolean supportsCatalogsInProcedureCalls() {
return false;
return true;
}

@Override
public boolean supportsCatalogsInTableDefinitions() {
return false;
return true;
}

@Override
public boolean supportsCatalogsInIndexDefinitions() {
return false;
return true;
}

@Override
public boolean supportsCatalogsInPrivilegeDefinitions() {
return false;
return true;
}

@Override
Expand Down Expand Up @@ -3305,7 +3305,7 @@ public boolean insertsAreDetected(int type) {

@Override
public boolean supportsBatchUpdates() {
return false;
return true;
}

@Override
Expand Down
7 changes: 2 additions & 5 deletions ...d-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryArrowStructTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,11 +227,8 @@ public void structOfStructs() throws SQLException {
}

@Test
public void getSQLTypeNameIsNotSupported() {
Exception exception =
assertThrows(
SQLFeatureNotSupportedException.class, structWithPrimitiveValues::getSQLTypeName);
assertThat(exception.getMessage()).isEqualTo(CUSTOMER_TYPE_MAPPING_NOT_SUPPORTED);
public void getSQLTypeNameReturnsStruct() throws SQLException {
assertThat(structWithPrimitiveValues.getSQLTypeName()).isEqualTo("STRUCT");
}

@Test
Expand Down
7 changes: 2 additions & 5 deletions ...ud-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryJsonStructTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,11 +246,8 @@ public void structWithNullValue() throws SQLException {
}

@Test
public void getSQLTypeNameIsNotSupported() {
Exception exception =
assertThrows(
SQLFeatureNotSupportedException.class, structWithPrimitiveValues::getSQLTypeName);
assertThat(exception.getMessage()).isEqualTo(CUSTOMER_TYPE_MAPPING_NOT_SUPPORTED);
public void getSQLTypeName() throws SQLException {
assertThat(structWithPrimitiveValues.getSQLTypeName()).isEqualTo("STRUCT");
}

@Test
Expand Down
Loading