feat(spanner): add connection properties for min/max RPCs for DCP#12951
Merged
feat(spanner): add connection properties for min/max RPCs for DCP#12951
Conversation
Adds connection properties for min/max RPCs per channel for the dynamic channel pool. Also adds a connection property for concurrentStreamsLowWaterMark.
sakthivelmanii
approved these changes
Apr 29, 2026
rahul2393
approved these changes
Apr 29, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces new connection properties for the Dynamic Channel Pool (DCP) in the Spanner connection layer, specifically dcpMinRpcPerChannel, dcpMaxRpcPerChannel, and dcpConcurrentStreamsLowWatermark. These settings are integrated into the ConnectionOptions, ConnectionProperties, and SpannerPool logic, ensuring they are correctly used when creating Spanner instances and handled within the SpannerPoolKey. The feedback suggests replacing hardcoded default values in the property descriptions with references to the corresponding constants in SpannerOptions to ensure long-term documentation accuracy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds connection properties for min/max RPCs per channel for the dynamic channel pool. Also adds a connection property for concurrentStreamsLowWaterMark.