demo: regenerated biglake client library#12968
demo: regenerated biglake client library#12968diegomarquezp wants to merge 4 commits intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates query parameter names in the BigLake service stubs, shifting from camelCase to snake_case and kebab-case. Feedback highlights that these changes introduce inconsistencies across the library and deviate from standard Google Cloud API naming conventions; it is recommended to revert to camelCase for uniformity.
| fields, "hiveCatalogId", request.getHiveCatalogId()); | ||
| serializer.putQueryParam( | ||
| fields, "primaryLocation", request.getPrimaryLocation()); | ||
| fields, "primary_location", request.getPrimaryLocation()); |
There was a problem hiding this comment.
The query parameter name has been changed from primaryLocation to primary_location. While breaking changes are permissible for unreleased APIs, this snake_case naming is inconsistent with the kebab-case naming (e.g., page-size) introduced in HttpJsonIcebergCatalogServiceStub.java. Standardizing on camelCase is recommended for Google Cloud APIs.
| fields, "primary_location", request.getPrimaryLocation()); | |
| fields, "primaryLocation", request.getPrimaryLocation()); |
References
- Breaking changes to public APIs are permissible if the API has not yet been released.
| serializer.putQueryParam(fields, "page-size", request.getPageSize()); | ||
| serializer.putQueryParam(fields, "page-token", request.getPageToken()); |
There was a problem hiding this comment.
The query parameters page-size and page-token have been changed to kebab-case, which is non-standard for Google Cloud APIs and inconsistent with the snake_case used in HttpJsonHiveMetastoreServiceStub.java. While breaking changes are permissible for unreleased APIs, it is recommended to use camelCase for consistency and adherence to standard API patterns.
| serializer.putQueryParam(fields, "page-size", request.getPageSize()); | |
| serializer.putQueryParam(fields, "page-token", request.getPageToken()); | |
| serializer.putQueryParam(fields, "pageSize", request.getPageSize()); | |
| serializer.putQueryParam(fields, "pageToken", request.getPageToken()); |
References
- Breaking changes to public APIs are permissible if the API has not yet been released.
| ProtoRestSerializer.create(); | ||
| serializer.putQueryParam( | ||
| fields, "icebergCatalogId", request.getIcebergCatalogId()); | ||
| fields, "iceberg-catalog-id", request.getIcebergCatalogId()); |
There was a problem hiding this comment.
The query parameter iceberg-catalog-id uses kebab-case, which is non-standard for Google Cloud REST APIs and inconsistent with the snake_case used elsewhere in the library. Consider using camelCase for consistency.
| fields, "iceberg-catalog-id", request.getIcebergCatalogId()); | |
| fields, "icebergCatalogId", request.getIcebergCatalogId()); |
References
- Breaking changes to public APIs are permissible if the API has not yet been released.
b/505851871 Demo in #12968
1 participant
This is a generated demonstration PR corresponding to the changes on branch
biglake-p1(#12940). It validates output changes for client library stub code generated forjava-biglakemodule.