feat(datastore): Enable Otel metrics for custom Otel#12969
Merged
Conversation
…penTelemetryOptions
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors DatastoreOpenTelemetryOptions to ensure the OpenTelemetry instance is non-null by falling back to GlobalOpenTelemetry during the build process. It also makes setMetricsEnabled public, removes an obsolete test helper, and cleans up manual null checks in telemetry utilities. Review feedback suggests updating stale Javadoc, restoring @nonnull annotations with improved error messages, avoiding side effects in the builder's build() method, and removing redundant logic in the integration test teardown.
…atastoreOptionsTest
jinseopkim0
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark
setMetricsEnabled(boolean enabled)as public in DatastoreOpenTelemetryOptions.Some additional clean up about the Otel object and small fixes