chore(datastore): Clean up a few test files with new V3 changes#12987
chore(datastore): Clean up a few test files with new V3 changes#12987
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes explicit gRPC transport configurations from several test cases, relying instead on default settings, and simplifies redundant conditional logic in ITDatastoreClientSideMetrics and RemoteDatastoreHelper. The review feedback highlights that several variable names and comments still reference gRPC, which is now misleading given the changes. Recommendations include renaming these variables for clarity, removing stale comments, and consolidating redundant test logic.
| @@ -298,19 +293,19 @@ public void testHostWithGrpcAndHttp() { | |||
| String customHost = "http://localhost:" + PORT; | |||
| DatastoreOptions grpcTransportOptionsCustomHost = | |||
There was a problem hiding this comment.
The variable name grpcTransportOptionsCustomHost is misleading as it no longer explicitly sets gRPC transport. Consider renaming it to something like defaultOptionsCustomHost to accurately reflect its configuration.
2 participants
gRPC Transport is the new default so there is no need to explicitly set it.