Skip to content

fix: remove google/rpc exclusion to generate HttpResponse#12992

Merged
jinseopkim0 merged 1 commit intomainfrom
fix-http-proto-exclusion
May 4, 2026
Merged

fix: remove google/rpc exclusion to generate HttpResponse#12992
jinseopkim0 merged 1 commit intomainfrom
fix-http-proto-exclusion

Conversation

@jinseopkim0
Copy link
Copy Markdown
Contributor

b/504883966#comment8

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a minor formatting change in generation_config.yaml by adding a newline and removes a specific proto exclusion for google/rpc/http.proto in the generate_library.sh script. I have no feedback to provide.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

@jinseopkim0 jinseopkim0 marked this pull request as ready for review May 4, 2026 18:54
@jinseopkim0 jinseopkim0 requested a review from a team as a code owner May 4, 2026 18:54
@jinseopkim0 jinseopkim0 enabled auto-merge (squash) May 4, 2026 18:54
@jinseopkim0 jinseopkim0 requested a review from blakeli0 May 4, 2026 18:54
@jinseopkim0 jinseopkim0 merged commit 24b1719 into main May 4, 2026
132 of 136 checks passed
@jinseopkim0 jinseopkim0 deleted the fix-http-proto-exclusion branch May 4, 2026 18:59
zhumin8 added a commit to googleapis/librarian that referenced this pull request May 5, 2026
…rpc (#5828)

Remove hardcoded exclusion for `google/rpc` to keep in sync with recent
changes in google-cloud-java. See
googleapis/google-cloud-java#12992 and
googleapis/google-cloud-java#13005

Fix #5803
sofisl pushed a commit to googleapis/librarian that referenced this pull request May 5, 2026
…rpc (#5828)

Remove hardcoded exclusion for `google/rpc` to keep in sync with recent
changes in google-cloud-java. See
googleapis/google-cloud-java#12992 and
googleapis/google-cloud-java#13005

Fix #5803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants