Skip to content

fix(bigtable): resolve check-then-act race condition in VRpcImpl#13196

Merged
gcf-merge-on-green[bot] merged 1 commit into
googleapis:mainfrom
igorbernstein2:vrpc-impl-state-concurrency
May 14, 2026
Merged

fix(bigtable): resolve check-then-act race condition in VRpcImpl#13196
gcf-merge-on-green[bot] merged 1 commit into
googleapis:mainfrom
igorbernstein2:vrpc-impl-state-concurrency

Conversation

@igorbernstein2
Copy link
Copy Markdown
Contributor

No description provided.

@igorbernstein2 igorbernstein2 requested review from a team as code owners May 14, 2026 18:47
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the state transition logic in VRpcImpl.java to use an atomic compareAndSet operation when moving from State.NEW to State.STARTED. This change consolidates the state check and update into a single atomic step, removing redundant state.set calls and preventing potential race conditions. There were no review comments provided for this pull request, and I have no additional feedback to provide.

@igorbernstein2 igorbernstein2 added the automerge Merge the pull request once unit tests and other checks pass. label May 14, 2026
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 9853dd5 into googleapis:main May 14, 2026
168 of 169 checks passed
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 14, 2026
@igorbernstein2 igorbernstein2 deleted the vrpc-impl-state-concurrency branch May 14, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants