Skip to content

fix: remove google-cloud-bigtable-deps-bom from gapic-libraries-bom #13209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jinseopkim0 merged 2 commits into from
May 15, 2026
+7 −9
Merged

fix: remove google-cloud-bigtable-deps-bom from gapic-libraries-bom #13209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deaef27
fix: remove google-cloud-bigtable-deps-bom from gapic-libraries-bom
jinseopkim0 May 15, 2026
58e4e04
Merge branch 'main' into remove_bigtable_deps_bom
jinseopkim0 May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions gapic-libraries-bom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,13 +301,6 @@
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-bigtable-deps-bom</artifactId>
<version>2.78.1-SNAPSHOT</version><!-- {x-version-update:google-cloud-bigtable-deps:current} -->
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-billing-bom</artifactId>
Expand Down Expand Up @@ -1536,4 +1529,4 @@
</dependency>
</dependencies>
</dependencyManagement>
</project>
</project>
7 changes: 6 additions & 1 deletion sdk-platform-java/hermetic_build/library_generation/utils/pom_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ def __search_for_bom_artifact(
) -> List[BomConfig]:
repo = Path(repository_path).resolve()
module_exclusions = ["gapic-libraries-bom"]
sub_module_exclusions = ["google-cloud-bigtable-deps-bom"]
Comment thread
jinseopkim0 marked this conversation as resolved.
group_id_inclusions = [
"com.google.cloud",
"com.google.analytics",
Expand All @@ -104,7 +105,11 @@ def __search_for_bom_artifact(
if module.is_file() or module.name in module_exclusions:
continue
for sub_module in module.iterdir():
if sub_module.is_dir() and sub_module.name.endswith("-bom"):
if (
sub_module.is_dir()
and sub_module.name.endswith("-bom")
and sub_module.name not in sub_module_exclusions
):
Comment thread
jinseopkim0 marked this conversation as resolved.
root = etree.parse(f"{sub_module}/pom.xml").getroot()
group_id = root.find(f"{project_tag}{group_id_tag}").text
if group_id not in group_id_inclusions:
Expand Down
Loading