Skip to content

fix(hermetic_build): add grpc-gcp-java to module allowlist in root pom generator#13211

Merged
blakeli0 merged 2 commits into
googleapis:mainfrom
blakeli0:fix/allowlist-grpc-gcp
May 15, 2026
Merged

fix(hermetic_build): add grpc-gcp-java to module allowlist in root pom generator#13211
blakeli0 merged 2 commits into
googleapis:mainfrom
blakeli0:fix/allowlist-grpc-gcp

Conversation

@blakeli0
Copy link
Copy Markdown
Contributor

@blakeli0 blakeli0 commented May 15, 2026

This PR adds grpc-gcp-java to the MODULE_ALLOWLIST in pom_generator.py. This ensures that when grpc-gcp-java is migrated to the monorepo, the root pom generator will correctly preserve its module entry in the root pom.xml without requiring a java- prefix.

This unblocks #13184

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pom_generator.py utility to include grpc-gcp-java in the list of libraries processed by the get_version_from function. There are no review comments to address, and I have no further feedback to provide.

@blakeli0
Copy link
Copy Markdown
Contributor Author

cc: @zhumin8 A new repo grpc-gcp-java is being added to the monorepo, this PR is to make changes in the generator to unblock it.

@blakeli0 blakeli0 merged commit f7c8407 into googleapis:main May 15, 2026
305 of 308 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants