Skip to content

retry datastore transactions (#1242)#1932

Merged
neozwu merged 4 commits intogoogleapis:masterfrom
neozwu:retry-runintransaction
Apr 18, 2017
Merged

retry datastore transactions (#1242)#1932
neozwu merged 4 commits intogoogleapis:masterfrom
neozwu:retry-runintransaction

Conversation

@neozwu
Copy link
Contributor

@neozwu neozwu commented Apr 17, 2017

enable retry for datastore transactions.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 17, 2017
garrettjonesgoogle
garrettjonesgoogle reviewed Apr 17, 2017
View reviewed changes
...le-cloud-datastore/src/main/java/com/google/cloud/datastore/TransactionExceptionHandler.java Outdated
public RetryResult beforeEval(Exception exception) {
if (exception instanceof DatastoreException) {
DatastoreException e = getInnerException((DatastoreException) exception);
if (e.getCode() == 10 || e.getReason() == "ABORTED") {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

...le-cloud-datastore/src/main/java/com/google/cloud/datastore/TransactionExceptionHandler.java
return RetryResult.RETRY;
}
}
return Interceptor.RetryResult.CONTINUE_EVALUATION;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

...le-cloud-datastore/src/main/java/com/google/cloud/datastore/TransactionExceptionHandler.java Outdated
DatastoreImpl.EXCEPTION_HANDLER_INTERCEPTOR, TRANSACTION_EXCEPTION_HANDLER_INTERCEPTOR)
.build();
}
} No newline at end of file

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-datastore/src/test/java/com/google/cloud/datastore/it/ITDatastoreTest.java Outdated
transaction.get(KEY1);
if (attempts < 1) {
++attempts;
throw new DatastoreException(10,"","ABORTED",false,null);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-datastore/src/test/java/com/google/cloud/datastore/it/ITDatastoreTest.java Outdated
}
};
int result = DATASTORE.runInTransaction(callable);
assertTrue(result == 1);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-datastore/src/test/java/com/google/cloud/datastore/it/ITDatastoreTest.java
}

@Test
public void testRunInTransaction() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

coveralls commented Apr 17, 2017

Coverage Status

Changes Unknown when pulling 8c4b537 on neozwu:retry-runintransaction into ** on GoogleCloudPlatform:master**.

@neozwu
Copy link
Contributor Author

neozwu commented Apr 17, 2017

@garrettjonesgoogle PTAL

@coveralls
Copy link

coveralls commented Apr 17, 2017

Coverage Status

Coverage decreased (-0.007%) to 80.934% when pulling 0625f80 on neozwu:retry-runintransaction into b6a87b0 on GoogleCloudPlatform:master.

garrettjonesgoogle
garrettjonesgoogle reviewed Apr 17, 2017
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the suggestions below are addressed, and after @vam-google has also given approval.

...le-cloud-datastore/src/main/java/com/google/cloud/datastore/TransactionExceptionHandler.java
import com.google.cloud.ExceptionHandler;
import com.google.cloud.ExceptionHandler.Interceptor;

public class TransactionExceptionHandler {

This comment was marked as spam.

Sign in to view

...le-cloud-datastore/src/main/java/com/google/cloud/datastore/TransactionExceptionHandler.java Outdated
public class TransactionExceptionHandler {
public static final Interceptor TRANSACTION_EXCEPTION_HANDLER_INTERCEPTOR =
new Interceptor() {
private final int ABORTED_CODE = 10;

This comment was marked as spam.

Sign in to view

...le-cloud-datastore/src/main/java/com/google/cloud/datastore/TransactionExceptionHandler.java Outdated
public RetryResult beforeEval(Exception exception) {
if (exception instanceof DatastoreException) {
DatastoreException e = getInnerException((DatastoreException) exception);
if (e.getCode() == ABORTED_CODE || e.getReason() == "ABORTED") {

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

coveralls commented Apr 17, 2017

Coverage Status

Coverage decreased (-0.01%) to 80.928% when pulling 47e086d on neozwu:retry-runintransaction into b6a87b0 on GoogleCloudPlatform:master.

vam-google
vam-google approved these changes Apr 18, 2017
View reviewed changes
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the review comments are addressed.

google-cloud-datastore/src/main/java/com/google/cloud/datastore/DatastoreImpl.java Outdated
public <T> T runInTransaction(TransactionCallable<T> callable) {
return DatastoreHelper.runInTransaction(this, callable);
public <T> T runInTransaction(final TransactionCallable<T> callable) {
ExceptionHandler TRANSACTION_EXCEPTION_HANDLER = TransactionExceptionHandler.build();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

...le-cloud-datastore/src/main/java/com/google/cloud/datastore/TransactionExceptionHandler.java

public class TransactionExceptionHandler {
public static final Interceptor TRANSACTION_EXCEPTION_HANDLER_INTERCEPTOR =
new Interceptor() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-datastore/src/test/java/com/google/cloud/datastore/it/ITDatastoreTest.java Outdated

public Integer run(DatastoreReaderWriter transaction) {
transaction.get(KEY1);
if (attempts < 1) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Apr 18, 2017

LGTM after tests pass

@coveralls
Copy link

coveralls commented Apr 18, 2017

Coverage Status

Coverage decreased (-0.002%) to 80.939% when pulling e0aa253 on neozwu:retry-runintransaction into b6a87b0 on GoogleCloudPlatform:master.

@neozwu neozwu merged commit b355f4d into googleapis:master Apr 18, 2017
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-datastor…
df8bb69 
…e to v2.31.2 (#1932)
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@release-please
chore(main): release 2.28.2 (#1936)
53820c6 
🤖 I have created a release *beep* *boop*
---


## [2.28.2](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.28.1...v2.28.2) (2023-01-18)


### Bug Fixes

* Add a timeout on retry for retryable errors ([#1930](https://togithub.com/googleapis/java-bigquerystorage/issues/1930)) ([2d648cf](https://togithub.com/googleapis/java-bigquerystorage/commit/2d648cf9706a6e7bc155e8769ba7dda2a6bc3061))
* Add precision overwritten to 9 digit if the passed in JSON type is FLOAT or DOUBLE ([#1932](https://togithub.com/googleapis/java-bigquerystorage/issues/1932)) ([417bc6c](https://togithub.com/googleapis/java-bigquerystorage/commit/417bc6c76f7b9fa602721c3c183c487c5aab2e09))


### Dependencies

* Update dependency com.google.cloud:google-cloud-bigquery to v2.20.2 ([#1929](https://togithub.com/googleapis/java-bigquerystorage/issues/1929)) ([a95ae9d](https://togithub.com/googleapis/java-bigquerystorage/commit/a95ae9d708bd3e2d8f55297a6004a0d937c8d83f))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments

@vam-google vam-google vam-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@neozwu @coveralls @garrettjonesgoogle @vam-google @googlebot