Skip to content

Removing timeout settings that are set but never used#1934

Merged
garrettjonesgoogle merged 1 commit intogoogleapis:masterfrom
garrettjonesgoogle:alt
Apr 18, 2017
Merged

Removing timeout settings that are set but never used#1934
garrettjonesgoogle merged 1 commit intogoogleapis:masterfrom
garrettjonesgoogle:alt

Conversation

@garrettjonesgoogle
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 17, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 80.933% when pulling 730394c on garrettjonesgoogle:alt into b6a87b0 on GoogleCloudPlatform:master.

@michaelbausor
Copy link
Contributor

LGTM - did these used to be used? Or have they never been used at all?

@garrettjonesgoogle
Copy link
Member Author

Yes, they used to be used, but @vam-google 's PR #1738 stopped using them after RetrySettings was introduced. Now, going through RetrySettings (which can be set on ServiceOptions) is the correct thing to do.

@garrettjonesgoogle garrettjonesgoogle merged commit 455f739 into googleapis:master Apr 18, 2017
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
🤖 I have created a release *beep* *boop*
---


## [2.31.2](https://togithub.com/googleapis/java-datastore/compare/v2.31.1...v2.31.2) (2025-08-08)


### Bug Fixes

* **deps:** Update the Java code generator (gapic-generator-java) to 2.61.0 ([c7bd68d](https://togithub.com/googleapis/java-datastore/commit/c7bd68de82ec06f06c41cd12e87cc96a337dcd02))


### Dependencies

* Update dependency com.google.cloud:sdk-platform-java-config to v3.51.0 ([#1936](https://togithub.com/googleapis/java-datastore/issues/1936)) ([a25433f](https://togithub.com/googleapis/java-datastore/commit/a25433f805f957dc0beebaeef466aa20f14f8ccc))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants