Adding some unit tests for cloud spanner#2356
Conversation
googlebot
added
the
cla: yes
vkedia
changed the title
vam-google
left a comment
vam-google
left a comment
There was a problem hiding this comment.
LGTM.
A note, not directly related to the change. Some of previously non-static internal classes in SpannerImpl were made static as part of this review. The SpannerImpl class is pretty big (2500 lines), and contains more than 20 internall classes (allmost all static). It seems like SpannerImpl class is doing the job of a package (grouping various related classes together). I don't mean to do it in this PR, but please consider moving those classes to a separate package and extracting them from SpannerImpl.
| } catch (Exception e) { | ||
| throw Throwables.propagate(e); | ||
| Throwables.throwIfUnchecked(e); | ||
| throw new RuntimeException(e); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Don't merge this until I'm able to do a release with our current code in master |
|
@garrettjonesgoogle Can this be merged now? |
|
Yes it can be merged now. |
…onfig to v1.7.1 (#2356) * build(deps): update dependency com.google.cloud:google-cloud-shared-config to v1.7.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: PhongChuong <147636638+PhongChuong@users.noreply.github.com>
…legate to backend (#2356) * Remove validation check * allow the subquery test to run in prod env * chore: generate libraries at Mon Apr 13 17:41:06 UTC 2026 --------- Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
4 participants
No description provided.