Skip to content

Update pubsub code examples#3059

Merged
pongad merged 1 commit intogoogleapis:masterfrom
Fokko:fd-update-examples
Mar 21, 2018
Merged

Update pubsub code examples#3059
pongad merged 1 commit intogoogleapis:masterfrom
Fokko:fd-update-examples

Conversation

@Fokko
Copy link

@Fokko Fokko commented Mar 19, 2018

Hi all,

There are some changes in the recent API updates. I've updated the code examples to make it easier for others to conform to the changes. The current code examples are compatible with pubsub 0.40.0-beta.

Cheers, Fokko

@Fokko Fokko requested a review from pongad as a code owner March 19, 2018 19:56
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Mar 19, 2018
@Fokko
Copy link
Author

Fokko commented Mar 19, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 19, 2018
Copy link
Contributor

@pongad pongad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this.

Google Java style guide asks for 2-space indentation though. Could you please make this change. Other than that, this LGTM.

The code examples are outdated and need some rework. This is compatible
with pubsub 0.40.0-beta
@Fokko Fokko force-pushed the fd-update-examples branch from 4c379cd to 6a18e69 Compare March 20, 2018 23:14
@Fokko
Copy link
Author

Fokko commented Mar 20, 2018

Thanks @pongad for reviewing. I've revised the commit with two spaces. Cheers

@pongad pongad merged commit bdcdf59 into googleapis:master Mar 21, 2018
@Fokko Fokko deleted the fd-update-examples branch February 28, 2022 17:03
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
* chore(main): release 3.16.2

* chore: generate libraries at Tue Aug  5 14:08:17 UTC 2025

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
suztomo pushed a commit that referenced this pull request Mar 9, 2026
…3059)

* Changed the names of the row and column variables to make their purpose clear.

* Changed the code sample to reflect the real life usage

* Updated the query and column names

* Attempt to fix formatting.

* Modified the IT test to match the query in the sample.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: PhongChuong <147636638+PhongChuong@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants