Skip to content

Firestore:deprecated warnings removed #5459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sduskis merged 1 commit into from
Jun 11, 2019
Merged

Firestore:deprecated warnings removed #5459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .../google-cloud-firestore/src/main/java/com/google/cloud/firestore/CollectionReference.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import com.google.api.gax.rpc.ApiExceptions;
import com.google.cloud.firestore.v1.FirestoreClient.ListDocumentsPagedResponse;
import com.google.common.base.Preconditions;
import com.google.common.util.concurrent.MoreExecutors;
import com.google.firestore.v1.Document;
import com.google.firestore.v1.DocumentMask;
import com.google.firestore.v1.ListDocumentsRequest;
Expand Down Expand Up @@ -187,7 +188,8 @@ public ApiFuture<DocumentReference> add(@Nonnull final Map<String, Object> field
public DocumentReference apply(WriteResult writeResult) {
return documentReference;
}
});
},
MoreExecutors.directExecutor());
}

/**
Expand Down
4 changes: 3 additions & 1 deletion ...ts/google-cloud-firestore/src/main/java/com/google/cloud/firestore/DocumentReference.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import com.google.api.gax.rpc.ApiException;
import com.google.api.gax.rpc.ApiExceptions;
import com.google.cloud.firestore.v1.FirestoreClient.ListCollectionIdsPagedResponse;
import com.google.common.util.concurrent.MoreExecutors;
import com.google.firestore.v1.ListCollectionIdsRequest;
import java.util.Iterator;
import java.util.List;
Expand Down Expand Up @@ -130,7 +131,8 @@ private <T> ApiFuture<T> extractFirst(ApiFuture<List<T>> results) {
public T apply(List<T> results) {
return results.isEmpty() ? null : results.get(0);
}
});
},
MoreExecutors.directExecutor());
}

/**
Expand Down
10 changes: 7 additions & 3 deletions ...-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/Transaction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import com.google.api.core.ApiFuture;
import com.google.api.core.ApiFutures;
import com.google.common.base.Preconditions;
import com.google.common.util.concurrent.MoreExecutors;
import com.google.firestore.v1.BeginTransactionRequest;
import com.google.firestore.v1.BeginTransactionResponse;
import com.google.firestore.v1.RollbackRequest;
Expand Down Expand Up @@ -93,7 +94,8 @@ public Void apply(BeginTransactionResponse beginTransactionResponse) {
pending = true;
return null;
}
});
},
MoreExecutors.directExecutor());
}

/** Commits a transaction. */
Expand All @@ -120,7 +122,8 @@ ApiFuture<Void> rollback() {
public Void apply(Empty beginTransactionResponse) {
return null;
}
});
},
MoreExecutors.directExecutor());
}

/**
Expand All @@ -140,7 +143,8 @@ public ApiFuture<DocumentSnapshot> get(@Nonnull DocumentReference documentRef) {
public DocumentSnapshot apply(List<DocumentSnapshot> snapshots) {
return snapshots.isEmpty() ? null : snapshots.get(0);
}
});
},
MoreExecutors.directExecutor());
}

/**
Expand Down
4 changes: 3 additions & 1 deletion ...lients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import com.google.cloud.firestore.UserDataConverter.EncodingOptions;
import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableMap;
import com.google.common.util.concurrent.MoreExecutors;
import com.google.firestore.v1.CommitRequest;
import com.google.firestore.v1.CommitResponse;
import com.google.firestore.v1.Write;
Expand Down Expand Up @@ -657,7 +658,8 @@ public List<WriteResult> apply(CommitResponse commitResponse) {

return result;
}
});
},
MoreExecutors.directExecutor());
}

/** Checks whether any updates have been queued. */
Expand Down
4 changes: 2 additions & 2 deletions ...-cloud-firestore/src/test/java/com/google/cloud/firestore/conformance/TestDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23098,7 +23098,7 @@ public int getKindValue() {
/** <code>.tests.DocChange.Kind kind = 1;</code> */
public com.google.cloud.firestore.conformance.TestDefinition.DocChange.Kind getKind() {
com.google.cloud.firestore.conformance.TestDefinition.DocChange.Kind result =
com.google.cloud.firestore.conformance.TestDefinition.DocChange.Kind.valueOf(kind_);
com.google.cloud.firestore.conformance.TestDefinition.DocChange.Kind.forNumber(kind_);
return result == null
? com.google.cloud.firestore.conformance.TestDefinition.DocChange.Kind.UNRECOGNIZED
: result;
Expand Down Expand Up @@ -23510,7 +23510,7 @@ public Builder setKindValue(int value) {
/** <code>.tests.DocChange.Kind kind = 1;</code> */
public com.google.cloud.firestore.conformance.TestDefinition.DocChange.Kind getKind() {
com.google.cloud.firestore.conformance.TestDefinition.DocChange.Kind result =
com.google.cloud.firestore.conformance.TestDefinition.DocChange.Kind.valueOf(kind_);
com.google.cloud.firestore.conformance.TestDefinition.DocChange.Kind.forNumber(kind_);
return result == null
? com.google.cloud.firestore.conformance.TestDefinition.DocChange.Kind.UNRECOGNIZED
: result;
Expand Down