fix(ci): fix discovery.yaml by installing root dependencies - #8955
Merged
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
westarle
changed the title
westarle
force-pushed
the
fix-discovery-yaml
branch
from
July 23, 2026 16:19
7eb8775 to
ec50638
Compare
westarle
force-pushed
the
fix-discovery-yaml
branch
from
July 23, 2026 16:21
ec50638 to
ef04099
Compare
westarle
changed the title
…ixtures This fixes an issue where ESLint could not find the gts config because the root node_modules was empty, and ignores system-test/fixtures which are not included in the tsconfig. Tested locally with the following commands: ```bash npm install cd handwritten/bigquery npm install npm run types npm run fix ```
This fixes an issue where brace-expansion@5.0.8 dropped Node 18 support, breaking pnpm install on Node 18 runners. We override it to 5.0.7 which still supports Node 18.
westarle
force-pushed
the
fix-discovery-yaml
branch
from
July 24, 2026 18:39
519c18e to
516d70e
Compare
pearigee
reviewed
Jul 24, 2026
| @@ -16,6 +16,8 @@ jobs: | |||
| - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | |||
| with: | |||
| node-version: 16 | |||
Contributor
There was a problem hiding this comment.
Nit/Optional: May be worth bumping this to 22 or 24 while we are here.
pearigee
approved these changes
Jul 24, 2026
pearigee
reviewed
Jul 24, 2026
Bumps Node version to 22 and uses pnpm for dependency installation and script execution to respect global settings.
Adds 'root: true' to BigQuery's .eslintrc.json to prevent ESLint from cascading up to the monorepo root and loading conflicting versions of plugins (like prettier) when using pnpm.
Now that handwritten/bigquery/.eslintrc.json has 'root: true', ESLint no longer cascades to the monorepo root. Therefore, we no longer need to install root dependencies to satisfy the root ESLint configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where ESLint could not find the gts config because the root node_modules was empty, and ignores system-test/fixtures which are not included in the tsconfig.
Fixes #8954 🦕