feat: update API sources and regenerate - #9293
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the new BreakTemplateService for the Ad Manager API, including the necessary proto definitions, client library updates, and corresponding generated samples and tests. Additionally, it includes updates to the Data Manager API, such as new fields and error codes, and updates to the Meet API protos and samples. The review feedback identifies that several generated sample files contain incorrect placeholder types for 'requests' parameters, which should be updated to match the expected object array structure to improve clarity for users.
| * Required. The `AudienceSegment` objects to create. | ||
| * A maximum of 100 objects can be created in a batch. | ||
| */ | ||
| // const requests = [1,2,3,4] |
There was a problem hiding this comment.
The placeholder value for requests is [1,2,3,4], which is an array of numbers. However, the requests parameter expects an array of CreateAudienceSegmentRequest objects. The placeholder should be updated to reflect the correct type, for example: // const requests = [{}, {}]; to avoid confusion for users of this sample.
| // const requests = [1,2,3,4] | |
| // const requests = [{}, {}] |
There was a problem hiding this comment.
This feels like it might be a legit issue with the generator. (Not particularly for this PR though...)
| * Required. The `BreakTemplate` objects to create. | ||
| * A maximum of 100 objects can be created in a batch. | ||
| */ | ||
| // const requests = [1,2,3,4] |
There was a problem hiding this comment.
The placeholder value for requests is [1,2,3,4], which is an array of numbers. However, the requests parameter expects an array of CreateBreakTemplateRequest objects. The placeholder should be updated to reflect the correct type, for example: // const requests = [{}, {}]; to avoid confusion for users of this sample.
| // const requests = [1,2,3,4] | |
| // const requests = [{}, {}] |
| * Required. The `BreakTemplate` objects to update. | ||
| * A maximum of 100 objects can be updated in a batch. | ||
| */ | ||
| // const requests = [1,2,3,4] |
There was a problem hiding this comment.
The placeholder value for requests is [1,2,3,4], which is an array of numbers. However, the requests parameter expects an array of UpdateBreakTemplateRequest objects. The placeholder should be updated to reflect the correct type, for example: // const requests = [{}, {}]; to avoid confusion for users of this sample.
| // const requests = [1,2,3,4] | |
| // const requests = [{}, {}] |
| * Required. The request message specifying the resources to update. | ||
| * A maximum of 500 members can be modified in a batch. | ||
| */ | ||
| // const requests = [1,2,3,4] |
There was a problem hiding this comment.
The placeholder value for requests is [1,2,3,4], which is an array of numbers. However, the requests parameter expects an array of UpdateMemberRequest objects. The placeholder should be updated to reflect the correct type, for example: // const requests = [{}, {}]; to avoid confusion for users of this sample.
| // const requests = [1,2,3,4] | |
| // const requests = [{}, {}] |
| * Required. The request message specifying the resources to update. | ||
| * A maximum of 500 members can be modified in a batch. | ||
| */ | ||
| // const requests = [1,2,3,4] |
There was a problem hiding this comment.
The placeholder value for requests is [1,2,3,4], which is an array of numbers. However, the requests parameter expects an array of UpdateMemberRequest objects. The placeholder should be updated to reflect the correct type, for example: // const requests = [{}, {}]; to avoid confusion for users of this sample.
| // const requests = [1,2,3,4] | |
| // const requests = [{}, {}] |
|
"presubmit / lint (pull_request)" still failed. |
Actually these all kind of feel like generator issues - it's making code that has linter problems. @shivanee-p were you working on these earlier and have a PR? (ISTR..) If not, we can throw it onto the next sprint. We might also need a heap parameter boost for the monorepo-wide linter. |
2 participants
Update API sources and regenerate.
Included googleapis CLs
google/ads/admanager/v1
google/ads/datamanager/v1
google/apps/meet/v2
google/apps/meet/v2beta
google/bigtable/admin/v2
google/cloud/alloydb/v1alpha
google/cloud/alloydb/v1beta
google/cloud/apigateway/v1
google/cloud/auditmanager/v1
google/cloud/chronicle/v1
google/cloud/compute/v1
google/cloud/compute/v1beta
google/cloud/geminidataanalytics/v1alpha
google/cloud/kms/v1
google/cloud/retail/v2alpha
google/cloud/securesourcemanager/v1
google/cloud/vectorsearch/v1beta
google/cloud/visionai/v1
google/pubsub/v1
google/shopping/merchant/loyaltycustomers/v1