datastore: properly encode entity values#1206
Merged
callmehiphop merged 1 commit intogoogleapis:masterfrom Apr 5, 2016
Merged
Conversation
googlebot
added
the
cla: yes
Closed
|
Tested and LGTM. Thanks for the fast work (^^♪ As a side note, I think the error that was being thrown in #1205 should be in the callback of |
Contributor
Author
|
This error is our code's fault. When using gRPC, we have to agree to the format which Datastore expects to receive requests. If we give it data in any other format, gRPC prevents the request and throws an error saying Datastore won't understand it. After this fix, that won't happen again, so nothing to catch here. |
|
Ah, OK sounds good d(^_^)b |
sofisl
pushed a commit
that referenced
this pull request
Feb 26, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Mar 5, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Mar 11, 2026
* changes without context
autosynth cannot find the source of changes triggered by earlier changes in this
repository, or by version upgrades to tools such as linters.
* fix: use repo metadata to populate nodejs CODEOWNERS
* fix: use repo metadata to populate nodejs CODEOWNERS
* chore: small formatting tweaks
Co-authored-by: Benjamin Coe <bencoe@google.com>
Source-Author: Justin Beckwith <justin.beckwith@gmail.com>
Source-Date: Wed Feb 3 15:09:55 2021 -0800
Source-Repo: googleapis/synthtool
Source-Sha: 318e351e26ba65b2b3cfa3f61b3b64e3540c3525
Source-Link: googleapis/synthtool@318e351
* docs: fix case in README for samples
Co-authored-by: Megan Potter <57276408+feywind@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1205
We weren't following the schema for an embedded object inside of an entity. We didn't catch this because we weren't testing saving objects in our system tests -- added a test for that.
Thanks @richardkazuomiller for catching this!
You can test with: