common: create grpc operation object by callmehiphop · Pull Request #1525 · googleapis/google-cloud-node

callmehiphop · 2016-08-24T18:21:51Z

Moving the GrpcOperation section of the Bigtable PR to it's own PR.

.jscsrc

  "maximumLineLength": {
    "value": 80,
-    "allowUrlComments": true
+    "allowComments": true


coveralls · 2016-08-24T23:22:42Z

Coverage remained the same at 100.0% when pulling 8c38734 on callmehiphop:grpc-operation into 2b5795d on GoogleCloudPlatform:master.

callmehiphop · 2016-08-25T15:46:45Z

@stephenplusplus I think this should be good to go - PTAL!

packages/common/src/grpc-operation.js

+/**
+ * Cancel the operation.
+ *
+ * @param {function=} callback - The callback function.


🤖 I have created a release \*beep\* \*boop\* --- ### [5.16.1](https://www.github.com/googleapis/nodejs-spanner/compare/v5.16.0...v5.16.1) (2021-12-29) ### Bug Fixes * change in region ([#1523](https://www.github.com/googleapis/nodejs-spanner/issues/1523)) ([6caefc4](https://www.github.com/googleapis/nodejs-spanner/commit/6caefc4a0aafaa786a1d4b3fe3501d005d03bf6e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

common: create grpc operation object

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [aspect_rules_js](https://togithub.com/aspect-build/rules_js) | http_archive | minor | `v1.36.1` -> `v1.37.0` | --- ### Release Notes <details> <summary>aspect-build/rules_js (aspect_rules_js)</summary> ### [`v1.37.0`](https://togithub.com/aspect-build/rules_js/releases/tag/v1.37.0) [Compare Source](https://togithub.com/aspect-build/rules_js/compare/v1.36.1...v1.37.0) Many companies are successfully building with rules_js. If you're getting value from the project, please let us know! Just comment on our [Adoption Discussion](https://togithub.com/aspect-build/rules_js/discussions/1000). #### Using Bzlmod with Bazel 6: Add to your `MODULE.bazel` file: ```starlark bazel_dep(name = "aspect_rules_js", version = "1.37.0") ####### Node.js version ######### ### By default you get the node version from DEFAULT_NODE_VERSION in @rules_nodejs//nodejs:repositories.bzl ### Optionally you can pin a different node version: bazel_dep(name = "rules_nodejs", version = "5.8.2") node = use_extension("@rules_nodejs//nodejs:extensions.bzl", "node") node.toolchain(node_version = "16.14.2") ################################# npm = use_extension("@aspect_rules_js//npm:extensions.bzl", "npm", dev_dependency = True) npm.npm_translate_lock( name = "npm", pnpm_lock = "//:pnpm-lock.yaml", verify_node_modules_ignored = "//:.bazelignore", ) use_repo(npm, "npm") ``` #### Using WORKSPACE Paste this snippet into your `WORKSPACE` file: ```starlark load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "aspect_rules_js", sha256 = "7130820ce72d11489501479accc0072d45e53a916e4abc5e91b680b7374b3dad", strip_prefix = "rules_js-1.37.0", url = "https://togithub.com/aspect-build/rules_js/releases/download/v1.37.0/rules_js-v1.37.0.tar.gz", ) load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies") rules_js_dependencies() load("@rules_nodejs//nodejs:repositories.bzl", "DEFAULT_NODE_VERSION", "nodejs_register_toolchains") nodejs_register_toolchains( name = "nodejs", node_version = DEFAULT_NODE_VERSION, ) ### For convenience, npm_translate_lock does this call automatically. ### Uncomment if you don't call npm_translate_lock at all. #load("@bazel_features//:deps.bzl", "bazel_features_deps") #bazel_features_deps() load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock") npm_translate_lock( name = "npm", pnpm_lock = "//:pnpm-lock.yaml", verify_node_modules_ignored = "//:.bazelignore", ) load("@npm//:repositories.bzl", "npm_repositories") npm_repositories() ``` To use rules_js with bazel-lib 2.x, you must additionally register the coreutils toolchain. ```starlark load("@aspect_bazel_lib//lib:repositories.bzl", "register_coreutils_toolchains") register_coreutils_toolchains() ``` #### What's Changed - chore: upgrade to Aspect Workflows 5.9.0-rc.16 by [@gregmagolan](https://togithub.com/gregmagolan) in [https://togithub.com/aspect-build/rules_js/pull/1456](https://togithub.com/aspect-build/rules_js/pull/1456) - chore: switch to a gitpkg.vercel.app that doens't trip [https://togithub.com/pnpm/pnpm/issues/5414](https://togithub.com/pnpm/pnpm/issues/5414) by [@gregmagolan](https://togithub.com/gregmagolan) in [https://togithub.com/aspect-build/rules_js/pull/1459](https://togithub.com/aspect-build/rules_js/pull/1459) - chore: sort node toolchains in MODULE.bazel files by [@gregmagolan](https://togithub.com/gregmagolan) in [https://togithub.com/aspect-build/rules_js/pull/1461](https://togithub.com/aspect-build/rules_js/pull/1461) - chore: improve error messages on rctx.execute calls by [@gregmagolan](https://togithub.com/gregmagolan) in [https://togithub.com/aspect-build/rules_js/pull/1460](https://togithub.com/aspect-build/rules_js/pull/1460) - fix: only output warnings on lockfile parsing when regenerating lockfile by [@jbedard](https://togithub.com/jbedard) in [https://togithub.com/aspect-build/rules_js/pull/1454](https://togithub.com/aspect-build/rules_js/pull/1454) - feat: use yq to parse yaml file by [@gregmagolan](https://togithub.com/gregmagolan) in [https://togithub.com/aspect-build/rules_js/pull/1458](https://togithub.com/aspect-build/rules_js/pull/1458) **Full Changelog**: https://togithub.com/aspect-build/rules_js/compare/v1.36.1...v1.37.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/gapic-generator-typescript).

common: create grpc operation object

d137c82

callmehiphop added the core label Aug 24, 2016

callmehiphop assigned stephenplusplus Aug 24, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2016

callmehiphop reviewed Aug 24, 2016
View reviewed changes

.jscsrc Outdated

"maximumLineLength": {

"value": 80,

"allowUrlComments": true

"allowComments": true

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

callmehiphop added 2 commits August 24, 2016 16:00

removed useless code

c1d335c

updated jscs rules

8c38734

stephenplusplus reviewed Aug 25, 2016
View reviewed changes

packages/common/src/grpc-operation.js

/**

* Cancel the operation.

*

* @param {function=} callback - The callback function.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

callmehiphop added 2 commits August 25, 2016 13:51

added default callback for cancel

0203a2a

updated pending test

c2fe551

stephenplusplus merged commit 6065f83 into googleapis:master Aug 25, 2016

mikolajroszak mentioned this pull request Aug 1, 2022

[Snyk] Security upgrade node-fetch from 2.6.7 to 3.2.10 mikolajroszak/google-cloud-node#5

Open

mikolajroszak mentioned this pull request May 7, 2024

[Snyk] Upgrade node-fetch from 2.7.0 to 3.3.2 mikolajroszak/google-cloud-node#7

Open

sofisl pushed a commit that referenced this pull request Feb 24, 2026

docs: hiding MIN_PENDING_OPS from global docs (#1525)

583dc60

sofisl pushed a commit that referenced this pull request Feb 25, 2026

chore: remove V4SignedUrlQuery linter warning (#1525)

9359ae4

GautamSharda pushed a commit that referenced this pull request Mar 12, 2026

common: create grpc operation object (#1525)

88dbfd4

common: create grpc operation object

GautamSharda mentioned this pull request Mar 12, 2026

migrate code from googleapis/nodejs-common #7597

Merged

4 tasks

thiyaguk09 pushed a commit to thiyaguk09/google-cloud-node-fork that referenced this pull request Mar 18, 2026

chore: remove V4SignedUrlQuery linter warning (googleapis#1525)

92e9f01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

common: create grpc operation object#1525

common: create grpc operation object#1525
stephenplusplus merged 5 commits intogoogleapis:masterfrom
callmehiphop:grpc-operation

callmehiphop commented Aug 24, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Aug 24, 2016 •

edited

Loading

Uh oh!

callmehiphop commented Aug 25, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

callmehiphop commented Aug 24, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Aug 24, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

callmehiphop commented Aug 25, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coveralls commented Aug 24, 2016 •

edited

Loading