speech: fix docs to use correct event#1639
Closed
evancohen wants to merge 2 commits intogoogleapis:masterfrom
Closed
speech: fix docs to use correct event#1639evancohen wants to merge 2 commits intogoogleapis:masterfrom
evancohen wants to merge 2 commits intogoogleapis:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
googlebot
added
the
cla: no
|
CLAs look good, thanks! |
googlebot
added
cla: yes
Author
|
Nope. Please disregard. |
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
sofisl
pushed a commit
that referenced
this pull request
Feb 24, 2026
sofisl
pushed a commit
that referenced
this pull request
Feb 25, 2026
🤖 I have created a release \*beep\* \*boop\* --- ### [5.14.6](https://www.github.com/googleapis/nodejs-storage/compare/v5.14.5...v5.14.6) (2021-10-06) ### Bug Fixes * pass precondition opts to new file ([#1638](https://www.github.com/googleapis/nodejs-storage/issues/1638)) ([1523ca9](https://www.github.com/googleapis/nodejs-storage/commit/1523ca962fda070cf60e5b81d062e3a291461c83)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a little bit of head scratching I'm pretty sure that the docs are incorrect. The
requestStreamemits a'response'event:index.js#L484Right now they the docs claim it is
'data'. The event name should either be changed or the docs should be updated to reflect the actual name to prevent further confusion.Note: this may impact #1631