Skip to content

Comments

ci: set git user#1650

Merged
callmehiphop merged 3 commits intogoogleapis:masterfrom
stephenplusplus:spp--ci-git-user
Sep 29, 2016
Merged

ci: set git user#1650
callmehiphop merged 3 commits intogoogleapis:masterfrom
stephenplusplus:spp--ci-git-user

Conversation

@stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Sep 29, 2016

git add manifest.json json
git commit -m "Update docs for master [ci skip]"
*** Please tell me who you are.
Run
  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"
to set your account's default identity.

https://travis-ci.org/GoogleCloudPlatform/google-cloud-node/jobs/163785024#L1085

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 29, 2016
@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented Sep 29, 2016

Windows probs:

git config --global user.name "travis-ci"
exec: internal error
C:\projects\google-cloud-node\scripts\helpers.js:260
  if (response.code) {
              ^
TypeError: Cannot read property 'code' of null

https://ci.appveyor.com/project/GoogleCloudPlatform/google-cloud-node/build/1.0.235/job/boat9i11jv82e662

@stephenplusplus
Copy link
Contributor Author

I think I fixed it with my last commit.

@callmehiphop
Copy link
Contributor

Dang, must be a quirk of the submodule..? So there's already a line that tries to set the user, can we just add the --global flag to that?

https://github.com/GoogleCloudPlatform/google-cloud-node/blob/master/scripts/helpers.js#L318

@stephenplusplus
Copy link
Contributor Author

Woops, didn't see that. Added the global flag there.

@callmehiphop callmehiphop merged commit 910ab8d into googleapis:master Sep 29, 2016
miguelvelezsa pushed a commit that referenced this pull request Jul 23, 2025
* fix: expose underlying error with timeouts or retries

* Update retries.ts

* run lint
sofisl pushed a commit that referenced this pull request Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants