common: emit response event on correct stream#1847
Merged
callmehiphop merged 1 commit intogoogleapis:masterfrom Nov 30, 2016
Merged
common: emit response event on correct stream#1847callmehiphop merged 1 commit intogoogleapis:masterfrom
callmehiphop merged 1 commit intogoogleapis:masterfrom
Conversation
stephenplusplus
added
type: bug
googlebot
added
the
cla: yes
Contributor
Author
|
@harscoet can you test this out? Find - this.emit('response', grcpStatus);
+ stream.emit('response', grcpStatus); |
|
It fixes when error occured but now success callback is never called :/ |
Contributor
Author
|
Confirmed, the solution in this PR was a mistake. The original behavior was correct. I'll re-open your original issue and keep digging. Sorry about this! |
sofisl
pushed a commit
that referenced
this pull request
Feb 24, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Feb 25, 2026
* feat: support OLM Prefix/Suffix * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * updated to camel case * fix merge * fixed compile error * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * refactored tests * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * refactored tests * refactored tests Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Feb 26, 2026
* fix: set grpc useragent * fix: review comments
GautamSharda
pushed a commit
that referenced
this pull request
Mar 12, 2026
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Mar 17, 2026
thiyaguk09
pushed a commit
to thiyaguk09/google-cloud-node-fork
that referenced
this pull request
Mar 18, 2026
* feat: support OLM Prefix/Suffix * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * updated to camel case * fix merge * fixed compile error * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * refactored tests * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * refactored tests * refactored tests Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1846
We were incorrectly emitting the
responseevent on the gRPC request stream. As for why this fixes #1846... not so sure. Possibly a quirk of the inner-workings of the native Stream event handlers.