Skip to content

log: accept removeCircular as an option to write#2083

Merged
stephenplusplus merged 3 commits intogoogleapis:masterfrom
ofrobots:logging-removeCircular
Mar 15, 2017
Merged

log: accept removeCircular as an option to write#2083
stephenplusplus merged 3 commits intogoogleapis:masterfrom
ofrobots:logging-removeCircular

Conversation

@ofrobots
Copy link
Contributor

Callers of write (and related functions) can now pass removeCircular in
the options. This allows log entries to have circular references that
are replaced with '[Circular]' placeholder strings when encoded.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 15, 2017
@stephenplusplus stephenplusplus added the api: logging Issues related to the Cloud Logging API. label Mar 15, 2017
ofrobots and others added 3 commits March 15, 2017 11:21
Callers of write (and related functions) can now pass removeCircular in
the options. This allows log entries to have circular references that
are replaced with '[Circular]' placeholder strings when encoded.
@stephenplusplus stephenplusplus force-pushed the logging-removeCircular branch from 9bb3a59 to bd0038f Compare March 15, 2017 15:23
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 15, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling bd0038f on ofrobots:logging-removeCircular into ** on GoogleCloudPlatform:master**.

@stephenplusplus stephenplusplus merged commit d5df445 into googleapis:master Mar 15, 2017
@ofrobots
Copy link
Contributor Author

Do not land yet.

Turns out that this may not be the best way to do this – the options param to Log.prototype.write is expected to passed to the service (ie. is a service object). It is not acceptable for me to add a new property to it.

My preference would be to add a options object to the Log constructor. Thoughts?

@ofrobots
Copy link
Contributor Author

Oh well, the browser hadn't refreshed. This is already landed. This isn't a big deal as-landed since no one is passing in removeCircular as an argument yet. Let me put together a follow-on.

@ofrobots ofrobots deleted the logging-removeCircular branch March 15, 2017 18:13
sofisl pushed a commit that referenced this pull request Feb 26, 2026
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/nodejs-spanner/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the Cloud Logging API. cla: no This human has *not* signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants