log: accept removeCircular as an option to write#2083
log: accept removeCircular as an option to write#2083stephenplusplus merged 3 commits intogoogleapis:masterfrom
Conversation
Callers of write (and related functions) can now pass removeCircular in the options. This allows log entries to have circular references that are replaced with '[Circular]' placeholder strings when encoded.
9bb3a59 to
bd0038f
Compare
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
Changes Unknown when pulling bd0038f on ofrobots:logging-removeCircular into ** on GoogleCloudPlatform:master**. |
|
Do not land yet. Turns out that this may not be the best way to do this – the My preference would be to add a options object to the Log constructor. Thoughts? |
|
Oh well, the browser hadn't refreshed. This is already landed. This isn't a big deal as-landed since no one is passing in removeCircular as an argument yet. Let me put together a follow-on. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/nodejs-spanner/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕
🤖 I have created a release *beep* *boop* --- ## [7.11.0](https://togithub.com/googleapis/nodejs-spanner/compare/v7.10.0...v7.11.0) (2024-07-29) ### Features * Add support for blind writes ([#2065](https://togithub.com/googleapis/nodejs-spanner/issues/2065)) ([62fc0a4](https://togithub.com/googleapis/nodejs-spanner/commit/62fc0a47327017c115466b9e89e53dbd778579af)) * **spanner:** Add samples for instance partitions ([#2083](https://togithub.com/googleapis/nodejs-spanner/issues/2083)) ([b91e284](https://togithub.com/googleapis/nodejs-spanner/commit/b91e2849056df9894e0590cb71e21c13319e6d70)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Callers of write (and related functions) can now pass removeCircular in
the options. This allows log entries to have circular references that
are replaced with '[Circular]' placeholder strings when encoded.