logging-bunyan: default removeCircular to true#2094
Merged
stephenplusplus merged 1 commit intogoogleapis:masterfrom Mar 16, 2017
Merged
logging-bunyan: default removeCircular to true#2094stephenplusplus merged 1 commit intogoogleapis:masterfrom
stephenplusplus merged 1 commit intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 14, 2026
This was referenced Jan 14, 2026
sofisl
pushed a commit
that referenced
this pull request
Feb 4, 2026
This was referenced Feb 4, 2026
sofisl
pushed a commit
that referenced
this pull request
Feb 25, 2026
#2094) * fix: remove async from final function which causes double invocation of callback * add catch clause
sofisl
pushed a commit
that referenced
this pull request
Feb 26, 2026
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-gax](https://togithub.com/googleapis/gax-nodejs) ([source](https://togithub.com/googleapis/gax-nodejs/tree/HEAD/gax)) | [`4.3.8` -> `4.3.9`](https://renovatebot.com/diffs/npm/google-gax/4.3.8/4.3.9) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/gax-nodejs (google-gax)</summary> ### [`v4.3.9`](https://togithub.com/googleapis/gax-nodejs/blob/HEAD/gax/CHANGELOG.md#439-2024-08-06) [Compare Source](https://togithub.com/googleapis/gax-nodejs/compare/google-gax-v4.3.8...google-gax-v4.3.9) ##### Bug Fixes - reduce duplicate code in streaming retries and add a test ([#​1636](https://togithub.com/googleapis/gax-nodejs/issues/1636)) ([83b52e1](https://togithub.com/googleapis/gax-nodejs/commit/83b52e14ba3bb1e9f0e079ea53e47ec32b4cfd45)) - test application cleanup ([#​1639](https://togithub.com/googleapis/gax-nodejs/issues/1639)) ([76ac496](https://togithub.com/googleapis/gax-nodejs/commit/76ac496fe42f1176df733d0adcc755bd4e773b10)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/googleapis/nodejs-spanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
sofisl
pushed a commit
that referenced
this pull request
Feb 26, 2026
](https://renovatebot.com){kind=link}
🤖 I have created a release *beep* *boop* --- ## [7.14.0](https://togithub.com/googleapis/nodejs-spanner/compare/v7.13.0...v7.14.0) (2024-08-14) ### Features * **spanner:** Add resource reference annotation to backup schedules ([#2093](https://togithub.com/googleapis/nodejs-spanner/issues/2093)) ([df539e6](https://togithub.com/googleapis/nodejs-spanner/commit/df539e665fe5d8fe01084b8d8cf6094c89b13d48)) ### Bug Fixes * **deps:** Update dependency google-gax to v4.3.9 ([#2094](https://togithub.com/googleapis/nodejs-spanner/issues/2094)) ([487efc0](https://togithub.com/googleapis/nodejs-spanner/commit/487efc091e0e143d3c59ac63d66005133b1ef2e5)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1987
winston doesn't have this issue as objects will get formatted with
util.inspectwhich will naturally removes circularity.