common: allow promises to resolve with a single arg#2096
Merged
stephenplusplus merged 3 commits intogoogleapis:masterfrom Mar 17, 2017
callmehiphop:dg--single-promise-resolve
Merged
common: allow promises to resolve with a single arg#2096stephenplusplus merged 3 commits intogoogleapis:masterfrom callmehiphop:dg--single-promise-resolve
stephenplusplus merged 3 commits intogoogleapis:masterfrom
callmehiphop:dg--single-promise-resolve
Conversation
googlebot
added
the
cla: yes
Contributor
Author
| * | ||
| * @param {function} originalMethod - The method to promisify. | ||
| * @param {object=} options - Promise options. | ||
| * @param {boolean} options.singular - Resolve the promise with single arg |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| } | ||
|
|
||
| resolve(callbackArgs); | ||
| if (options.singular && callbackArgs.length === 1) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Changes Unknown when pulling 3d03749 on callmehiphop:dg--single-promise-resolve into ** on GoogleCloudPlatform:master**. |
sofisl
pushed a commit
that referenced
this pull request
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.