Coverage branch: codec.js#2147
Merged
lukesneeringer merged 1 commit intogoogleapis:masterfrom Mar 28, 2017
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
|
Did we expect coverage to stay the same? Merge away If so! |
Contributor
Author
|
Yeah, it fixed a missing branch, not a missing line. |
Contributor
|
Ah, got it. Thanks! 🌴 not 📉 |
sofisl
pushed a commit
that referenced
this pull request
Feb 25, 2026
…am and using smaller queue of promises (#2147)
sofisl
pushed a commit
that referenced
this pull request
Feb 26, 2026
sofisl
pushed a commit
that referenced
this pull request
Feb 26, 2026
…l.createSessions (#2145) This change adds tracing for Database.batchCreateSessions as well as SessionPool.createSessions which was raised as a big need. This change is a premise to finishing up tracing Transaction. While here, also folded in the async/await fix to avoid day+ long code review lag and then 3+ hours just to run tests per PR: OpenTelemetry cannot work correctly for async/await if there isn't a set AsyncHooksManager, but we should not burden our customers with this type of specialist knowledge, their code should just work and this change performs such a check. Later on we shall file a feature request with the OpenTelemetry-JS API group to give us a hook to detect if we've got a live asyncHooksManager instead of this mandatory comparison to ROOT_CONTEXT each time. Fixes #2146 Updates #2079 Spun out of PR #2122 Supersedes PR #2147
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick addition of a test to catch an
ifbranch we missed.