spanner: add txn id to reads and remove promise support in runTransaction#2148
Merged
stephenplusplus merged 1 commit intogoogleapis:masterfrom Mar 29, 2017
callmehiphop:dg--spanner-txn-id
Merged
spanner: add txn id to reads and remove promise support in runTransaction#2148stephenplusplus merged 1 commit intogoogleapis:masterfrom callmehiphop:dg--spanner-txn-id
stephenplusplus merged 1 commit intogoogleapis:masterfrom
callmehiphop:dg--spanner-txn-id
Conversation
googlebot
added
the
cla: yes
vkedia
reviewed
Mar 29, 2017
| @@ -1105,7 +1088,9 @@ var spanner = new Spanner(env); | |||
| }); | |||
|
|
|||
| if (attempts < 2) { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| if (attempts < 2) { | ||
| runOtherTransaction(transaction); | ||
| runOtherTransaction(function() { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
sofisl
pushed a commit
that referenced
this pull request
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2118
Closes #2144
Per #2118 (comment) I'm extracting out the critical parts while we decide on how best to integrate Promises within
runTransaction.