Skip to content

Comments

Monitoring: Regeneration#2427

Closed
landrito wants to merge 1 commit intogoogleapis:masterfrom
landrito:monitoring
Closed

Monitoring: Regeneration#2427
landrito wants to merge 1 commit intogoogleapis:masterfrom
landrito:monitoring

Conversation

@landrito
Copy link
Contributor

@landrito landrito commented Jun 30, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 30, 2017
swcloud
swcloud suggested changes Jun 30, 2017
View reviewed changes
packages/monitoring/package.json Outdated
"version": "0.3.0",
"author": "Google Inc",
"description": "Stackdriver Monitoring API client for Node.js",
"contributors": [

This comment was marked as spam.

Sign in to view

packages/monitoring/src/v3/index.js Outdated
);

module.exports = v3; No newline at end of file
module.exports = v3;

This comment was marked as spam.

Sign in to view

packages/monitoring/smoke-test/metric_service_smoke_test.js Outdated
.on('end', done);
});
}); No newline at end of file
});

This comment was marked as spam.

Sign in to view

packages/monitoring/src/index.js Outdated
module.exports.v3.group = groupV3;
module.exports.v3.metric = metricV3;
module.exports.v3.types = v3Protos; No newline at end of file
module.exports.v3.types = v3Protos;

This comment was marked as spam.

Sign in to view

packages/monitoring/smoke-test/metric_service_smoke_test.js Outdated
describe('MetricServiceSmokeTest', function() {
if (!process.env.SMOKE_TEST_PROJECT) {
throw new Error("Usage: SMOKE_TEST_PROJECT=<project_id> node #{$0}");
throw new Error("Usage: SMOKE_TEST_PROJECT=<project_id> npm run smoke-test");

This comment was marked as spam.

Sign in to view

swcloud
swcloud suggested changes Jun 30, 2017
View reviewed changes
packages/monitoring/src/v3/group_service_client.js
var DEFAULT_SERVICE_PORT = 443;

var CODE_GEN_NAME_VERSION = 'gapic/0.7.1';
var CODE_GEN_NAME_VERSION = 'gapic/0.3.0';

This comment was marked as spam.

Sign in to view

packages/monitoring/src/v3/index.js
return result;
}

v3.GAPIC_VERSION = '0.3.0';

This comment was marked as spam.

Sign in to view

packages/monitoring/src/v3/metric_service_client.js
var DEFAULT_SERVICE_PORT = 443;

var CODE_GEN_NAME_VERSION = 'gapic/0.7.1';
var CODE_GEN_NAME_VERSION = 'gapic/0.3.0';

This comment was marked as spam.

Sign in to view

@landrito
Copy link
Contributor Author

landrito commented Jun 30, 2017

@swcloud Made this simply the generated packages including the docs. I'll address the hand-edits in toolkit.

@swcloud
Copy link
Contributor

swcloud commented Jul 1, 2017

@landrito LGTM except the GAPIC version number. @stephenplusplus may also need to approve it before he merges to the master.

stephenplusplus
stephenplusplus suggested changes Jul 1, 2017
View reviewed changes
Copy link
Contributor

@stephenplusplus stephenplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume most of these comments apply to #2428 as well.

packages/monitoring/package.json
"email": "sawchuk@gmail.com"
}
],
"version": "0.3.0",

This comment was marked as spam.

Sign in to view

packages/monitoring/smoke-test/metric_service_smoke_test.js
'use strict';

describe('MetricServiceSmokeTest', function() {
if (!process.env.SMOKE_TEST_PROJECT) {

This comment was marked as spam.

Sign in to view

packages/monitoring/smoke-test/metric_service_smoke_test.js
client.listMonitoredResourceDescriptors({name: formattedName}).then(function(responses) {
var resources = responses[0];
for (var i = 0; i < resources.length; ++i) {
console.log(resources[i]);

This comment was marked as spam.

Sign in to view

packages/monitoring/smoke-test/metric_service_smoke_test.js

describe('MetricServiceSmokeTest', function() {
if (!process.env.SMOKE_TEST_PROJECT) {
throw new Error("Usage: SMOKE_TEST_PROJECT=<project_id> node #{$0}");

This comment was marked as spam.

Sign in to view

packages/monitoring/smoke-test/metric_service_smoke_test.js
// The actual response object, if necessary.
// var rawResponse = responses[2];
for (var i = 0; i < resources.length; ++i) {
console.log(resources[i])

This comment was marked as spam.

Sign in to view

packages/monitoring/src/index.js
*/
'use strict';

/*!

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/monitoring/package.json
"devDependencies": {
"mocha": "^3.1.2"
"mocha": "^3.2.0",
"through2": "^2.0.3"

This comment was marked as spam.

Sign in to view

@stephenplusplus stephenplusplus removed their assignment Jul 19, 2017
@stephenplusplus stephenplusplus added the api: monitoring Issues related to the Cloud Monitoring API. label Jul 19, 2017
@landrito landrito closed this Aug 8, 2017
sofisl pushed a commit that referenced this pull request Feb 24, 2026
@release-please
chore(main): release 7.11.6 (#2427)
cb7c191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@stephenplusplus stephenplusplus stephenplusplus requested changes

@swcloud swcloud swcloud requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: monitoring Issues related to the Cloud Monitoring API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@landrito @swcloud @stephenplusplus @googlebot