Increase the deadline for spanner rpcs#2450
Merged
stephenplusplus merged 2 commits intomasterfrom Jul 31, 2017
Merged
Conversation
Cloud Spanner RPCs such as Commit and Streaming calls can take a long time to run in certain cases. Increased the deadline for those to be 1 hour. Ideally we would not want any deadlines for these calls. Also marked most of the rpcs as idempotent.
googlebot
added
the
cla: yes
| "max_rpc_timeout_millis": 60000, | ||
| "total_timeout_millis": 600000 | ||
| } | ||
| "long_running": { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
This is a generated file-- does https://github.com/googleapis/api-client-staging/blob/master/generated/nodejs/spanner/src/v1/spanner_client_config.json need to be updated first? |
Contributor
Contributor
Author
|
I see. Ok I will update that. Once I do that, will it automatically get copied here? |
Contributor
|
I don't believe it's automatic, but @lukesneeringer or @bjwatson should know how to get it copied over here. |
Contributor
|
It is not automatic, but we can do it. @stephenplusplus, if you know the new values, feel free to just change it to the new values. That would be faster. |
sofisl
pushed a commit
that referenced
this pull request
Feb 24, 2026
sofisl
pushed a commit
that referenced
this pull request
Feb 25, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud Spanner RPCs such as Commit and Streaming calls can take a long time to run in certain cases. Increased the deadline for those to be 1 hour. Ideally we would not want any deadlines for these calls.
Also marked most of the rpcs as idempotent.