fix: Refactor the parameters for timestamp expressions and fix bug for timeGranularity lowercase#7856
Merged
yvonnep165 merged 3 commits intomainfrom Mar 27, 2026
Merged
Conversation
…granularity value to lowercase
dlarocque
approved these changes
Mar 26, 2026
| isAbsent(): BooleanExpression; | ||
| isError(): BooleanExpression; | ||
| isType(type: Type): BooleanExpression; | ||
| isType(type: string): BooleanExpression; |
Contributor
There was a problem hiding this comment.
Thanks for fixing this- i forgot to generate the API report when i added this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes on top of #7826:
TimeUnitand refactor thetimestampAdd,timestampSubtractandtimestampDiffexpressions to use this valueTimeGranularityto include typeTimeUnitdirectly and change the camelCase value to lowercasetimestampTruncateandtimestampExtractBEGIN_COMMIT_OVERRIDE
chore(firestore): Refactor the parameters for timestamp expressions and fix bug for timeGranularity lowercase
END_COMMIT_OVERRIDE