Skip to content

ci: resolve type conflict for @sinonjs/fake-timers for all generated packages#7995

Merged
shivanee-p merged 8 commits intomainfrom
pearigee-fix-sinon-issue
Apr 10, 2026
Merged

ci: resolve type conflict for @sinonjs/fake-timers for all generated packages#7995
shivanee-p merged 8 commits intomainfrom
pearigee-fix-sinon-issue

Conversation

@pearigee
Copy link
Copy Markdown
Contributor

@pearigee pearigee commented Apr 8, 2026

Much like in #7962, we are experiencing a type conflict with Sinon. This is now blocking releases: https://louhi.corp.goog/5389666278309888/flow-detail/f39e9a7e-62df-48f6-98b2-7d3614e524fc?branch=main

While the permanent fix is being resolved in the Sinon repository (see sinonjs/fake-timers#559), we will pin the types to unblock releases in the mean time.

@pearigee pearigee requested a review from a team as a code owner April 8, 2026 21:54
@shivanee-p shivanee-p added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 8, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2026
@pearigee pearigee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2026
@shivanee-p shivanee-p added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2026
@pearigee pearigee changed the title fix: resolve type conflict for @sinonjs/fake-timers for all packages fix: resolve type conflict for @sinonjs/fake-timers for all generated packages Apr 9, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2026
@pearigee pearigee changed the title fix: resolve type conflict for @sinonjs/fake-timers for all generated packages ci: resolve type conflict for @sinonjs/fake-timers for all generated packages Apr 9, 2026
@shivanee-p shivanee-p added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2026
@shivanee-p shivanee-p merged commit c35255e into main Apr 10, 2026
36 checks passed
@shivanee-p shivanee-p deleted the pearigee-fix-sinon-issue branch April 10, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants