chore: disable sample tests for packages/*#7996
Merged
Conversation
product-auto-label
bot
added
the
samples
quirogas
approved these changes
Apr 8, 2026
shivanee-p
approved these changes
Apr 9, 2026
shivanee-p
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package "sample" tests are also failing or flaky. This is blocking my fix to #7976 (the sinonjs type conflict) with https://github.com/googleapis/google-cloud-node/pull/7995/changes .
A few examples of failing or flaky tests:
For example google-cloud-apigeeregistry is failing with a random DEADLINE_EXCEEDED.
Another one, for google-area120-tables, we get a UNIMPLEMENTED: Received HTTP status code 404. This product is down (maybe intentionally turned down?) and their service is unreachable.
These sample tests essentially boil down to smoke tests of the services each client calls. These are not testing any behavior and each service should be responsible for managing their own uptime.
In #7921, we are considering deleting them.