Skip to content

fix: Do not publish the protos to npm#8079

Merged
gcf-merge-on-green[bot] merged 3 commits intomainfrom
protos-do-not-publish
Apr 20, 2026
Merged

fix: Do not publish the protos to npm#8079
gcf-merge-on-green[bot] merged 3 commits intomainfrom
protos-do-not-publish

Conversation

@danieljbruce
Copy link
Copy Markdown
Contributor

Description

This change solves googleapis/librarian#4820 and ensures that the .proto files don't get published to npm.

Impact

This just cleans up the built packages. It will make customer dependencies smaller which could improve the performance of their applications by shrinking their node_modules folders.

Testing

Only package.json files are modified in this change so tests against the source code aren't really required here.

@danieljbruce danieljbruce requested a review from a team as a code owner April 20, 2026 15:48
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the "build/protos" directory from the "files" array in the "package.json" files across a large number of Google Cloud Node.js client libraries. This change ensures that proto files are no longer included in the published npm packages. There are no review comments to address, and I have no feedback to provide.

Copy link
Copy Markdown
Contributor

@quirogas quirogas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danieljbruce danieljbruce added the automerge Merge the pull request once unit tests and other checks pass. label Apr 20, 2026
@gcf-merge-on-green gcf-merge-on-green bot merged commit 816216b into main Apr 20, 2026
36 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 20, 2026
@gcf-merge-on-green gcf-merge-on-green bot deleted the protos-do-not-publish branch April 20, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants