chore: remove unused system test from core/projectify#8167
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request involves the deletion of system test configurations, ESLint rules, and test files for the core/paginator package. A review comment points out a potential high-severity issue where these files may have been deleted accidentally, as the changes appear inconsistent with the intended scope of the pull request which likely targeted core/projectify instead.
I am having trouble creating individual review comments. Click here to see my feedback.
core/paginator/.kokoro/continuous/node18/system-test.cfg (1-12)
The deletion of this configuration file for core/paginator is inconsistent with the PR title and description, which only mention core/projectify. This may be an accidental deletion of the wrong package's configuration, possibly instead of a similar file in the core/projectify directory.
shivanee-p
approved these changes
May 4, 2026
thiyaguk09
pushed a commit
to thiyaguk09/google-cloud-node-fork
that referenced
this pull request
May 5, 2026
* chore: remove unused system test from core/projectify * whoops, deleted the wrong config file * remove uneeded test script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package has no system tests (despite the configuration existing for them).
The test file just contains
console.warn('no system tests available 👻');. However there is still a job configured to execute this file. The internal configuration for this was removed in cl/910261720.