Conversation
This was added during the migration in #7606 but there is no manifest entry associated with these, and they don't look like they are released things.
This was referenced May 5, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes several test fixture entries from the release-please-config.json file, specifically those located under the core/generator/gapic-generator-typescript/test-fixtures path for speech and tasks services. I have no feedback to provide.
codyoss
added a commit
to googleapis/synthtool
that referenced
this pull request
May 5, 2026
Excludes `core/generator/gapic-generator-typescript/test-fixtures` from directory traversal in `node_mono_repo.py` to prevent the post-processor from re-adding them to `release-please-config.json`. See googleapis/google-cloud-node#8171 for an example of the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added during the migration in #7606 but there is no manifest entry associated with these, and they don't look like they are released things.