Skip to content

chore: remove bad entries#8171

Open
codyoss wants to merge 3 commits intomainfrom
rm-bad-config
Open

chore: remove bad entries#8171
codyoss wants to merge 3 commits intomainfrom
rm-bad-config

Conversation

@codyoss
Copy link
Copy Markdown
Member

@codyoss codyoss commented May 5, 2026

This was added during the migration in #7606 but there is no manifest entry associated with these, and they don't look like they are released things.

This was added during the migration in #7606 but there is no
manifest entry associated with these, and they don't look like they
are released things.
@codyoss codyoss requested a review from a team as a code owner May 5, 2026 14:11
This was referenced May 5, 2026
@codyoss codyoss requested a review from pearigee May 5, 2026 14:12
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several test fixture entries from the release-please-config.json file, specifically those located under the core/generator/gapic-generator-typescript/test-fixtures path for speech and tasks services. I have no feedback to provide.

codyoss added a commit to googleapis/synthtool that referenced this pull request May 5, 2026
Excludes `core/generator/gapic-generator-typescript/test-fixtures`
from directory traversal in `node_mono_repo.py` to prevent the
post-processor from re-adding them to `release-please-config.json`.

See googleapis/google-cloud-node#8171 for
an example of the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant