Skip to content

chore: relocate three packages from packages, as they are handwritten#8263

Merged
feywind merged 9 commits into
mainfrom
feywind-move-cores
May 20, 2026
Merged

chore: relocate three packages from packages, as they are handwritten#8263
feywind merged 9 commits into
mainfrom
feywind-move-cores

Conversation

@feywind
Copy link
Copy Markdown
Contributor

@feywind feywind commented May 13, 2026 •
edited
Loading

As the title says.

googleapis/librarian#4803

  • gapic-processing-node -> core
  • typeless-sample-bot -> core
  • google-cloud-dns -> handwritten

Fixes: #8122 🦖

@feywind feywind requested a review from a team as a code owner May 13, 2026 20:34
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces significant updates to the gapic-node-processing package, focusing on library bootstrapping, combining multiple libraries, and template-based generation of READMEs and other project files. The changes include new CLI commands, updated templating logic, and an extensive set of test fixtures for Google Analytics and Google Cloud Speech libraries to ensure correct processing of combined GAPIC clients. I have no feedback to provide.

@feywind feywind changed the title chore: relocate two packages from packages to core, as they are handwritten chore: relocate three packages from packages to core, as they are handwritten May 14, 2026
@feywind feywind changed the title chore: relocate three packages from packages to core, as they are handwritten chore: relocate three packages from packages, as they are handwritten May 14, 2026
@feywind feywind mentioned this pull request May 14, 2026
Closed
@feywind
Copy link
Copy Markdown
Contributor Author

feywind commented May 19, 2026

Since this is just relocating files, the header check failure is expected.

@quirogas quirogas self-requested a review May 19, 2026 22:15
@pearigee
Copy link
Copy Markdown
Contributor

pearigee commented May 19, 2026

Is the release-please-config.json correct? I see that typeless-sample-bot and gapic-node-processing may be referencing the wrong directory? google-cloud-dns is referencing handwritten now in release-please-config.json.

However, we also have a release-please-submodules.json which has the rest of our core/handwritten libraries. Should all of these libraries move there instead?

@quirogas
chore: update file references (#8324)
aa810d1 
* chore: fix license and copyright headers to resolve CI failures

* chore: use single instead of double quoutes

* chore: delete remaining dns files from packages directory

* chore: update references and configurations for relocated packages
@feywind
Copy link
Copy Markdown
Contributor Author

feywind commented May 20, 2026

tysm for the catches! I'm still not completely familiar with all the repo edges.

@feywind feywind merged commit 2503957 into main May 20, 2026
26 checks passed
@feywind feywind deleted the feywind-move-cores branch May 20, 2026 17:18
@feywind feywind mentioned this pull request May 25, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quirogas quirogas quirogas approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NodeJS: Relocate non-generated packages out of the packages tree

3 participants

@feywind @pearigee @quirogas