Skip to content

fix(spanner): resolve prelint, eslint, and prettier CI build failures#8359

Merged
sakthivelmanii merged 3 commits into
mainfrom
fix-spanner-lint-errors
May 27, 2026
Merged

fix(spanner): resolve prelint, eslint, and prettier CI build failures#8359
sakthivelmanii merged 3 commits into
mainfrom
fix-spanner-lint-errors

Conversation

@sakthivelmanii
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@sakthivelmanii sakthivelmanii requested a review from a team as a code owner May 26, 2026 17:20
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the Spanner API. label May 26, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds 'system-test/fixtures' to the ESLint ignore list, removes the 'prelint' script from 'package.json', and adds a trailing comma to an assertion in 'system-test/spanner.ts'. I have no feedback to provide as there are no review comments.

@sakthivelmanii sakthivelmanii added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2026
@sakthivelmanii sakthivelmanii force-pushed the fix-spanner-lint-errors branch from 7b2b9cc to cdffc07 Compare May 26, 2026 20:09
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2026
@sakthivelmanii sakthivelmanii force-pushed the fix-spanner-lint-errors branch 7 times, most recently from c5cb9ba to a5a5768 Compare May 27, 2026 07:33
@alkatrivedi alkatrivedi added the owlbot:run Add this label to trigger the Owlbot post processor. label May 27, 2026
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 27, 2026
Comment thread handwritten/spanner/package.json Outdated
@sakthivelmanii sakthivelmanii force-pushed the fix-spanner-lint-errors branch from a5a5768 to 5a6df97 Compare May 27, 2026 09:39
@sakthivelmanii sakthivelmanii merged commit 600ccca into main May 27, 2026
31 checks passed
@sakthivelmanii sakthivelmanii deleted the fix-spanner-lint-errors branch May 27, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants