Skip to content

build: add GCB build file for handwritten Pub/Sub#8362

Merged
feywind merged 5 commits into
mainfrom
feywind-gcb-pubsub
Jun 2, 2026
Merged

build: add GCB build file for handwritten Pub/Sub#8362
feywind merged 5 commits into
mainfrom
feywind-gcb-pubsub

Conversation

@feywind

@feywind feywind commented May 26, 2026

Copy link
Copy Markdown
Contributor

This adds the config file for getting Pub/Sub system tests running under GCB instead of kokoro.

Related to #8025

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Cloud Build configuration (cloudbuild.yaml) for running handwritten Pub/Sub system tests and coverage reporting. The review feedback highlights several improvement opportunities: replacing npm install with npm ci for reliable CI/CD builds, using the built-in ${PROJECT_ID} substitution instead of a hardcoded custom variable, and executing the nyc binary via the standard ./node_modules/.bin/nyc path rather than its internal package structure.

Comment thread handwritten/pubsub/cloudbuild.yaml
Comment thread handwritten/pubsub/cloudbuild.yaml Outdated
Comment thread handwritten/pubsub/cloudbuild.yaml Outdated
Comment thread handwritten/pubsub/cloudbuild.yaml Outdated
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2026
@feywind feywind closed this May 28, 2026
@feywind feywind reopened this May 28, 2026
@feywind feywind merged commit 7f42fd5 into main Jun 2, 2026
42 checks passed
@feywind feywind deleted the feywind-gcb-pubsub branch June 2, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kokoro:force-run Add this label to force Kokoro to re-run the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants