Skip to content

chore: migrate google-ads-admanager to librarian#8555

Merged
jskeet merged 1 commit into
googleapis:mainfrom
jskeet:scripted-migrate-google-ads-admanager
Jun 11, 2026
Merged

chore: migrate google-ads-admanager to librarian#8555
jskeet merged 1 commit into
googleapis:mainfrom
jskeet:scripted-migrate-google-ads-admanager

Conversation

@jskeet

@jskeet jskeet commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@jskeet jskeet requested a review from a team as a code owner June 11, 2026 09:54

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables client library generation for Google Ad Manager by removing the skip_generate flag and cleaning up various boilerplate and configuration files. Additionally, it updates the repository metadata, introduces the AdManagerError message definition to the protobuf configuration, and integrates the new admanager_error.proto across all service proto lists. I have no further feedback to provide as there are no review comments to address.

@jskeet

jskeet commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

I think this is okay - admanager_error.proto isn't listed in https://github.com/googleapis/googleapis/blob/master/google/ads/admanager/v1/BUILD.bazel, but is present in the directory... it's reasonable for us to generate all the proto files.

@JoeWang1127

Copy link
Copy Markdown
Contributor

Is this a new package?

@jskeet

jskeet commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Is this a new package?

No, it's a single new proto that isn't in the Bazel list of protos - we find all the protos in the API directory, hence the difference.

@jskeet jskeet merged commit 110024e into googleapis:main Jun 11, 2026
32 checks passed
@jskeet jskeet deleted the scripted-migrate-google-ads-admanager branch June 11, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants