Skip to content

chore: migrate google-storagetransfer to librarian#8580

Merged
quirogas merged 1 commit into
googleapis:mainfrom
jskeet:scripted-migrate-google-storagetransfer
Jun 12, 2026
Merged

chore: migrate google-storagetransfer to librarian#8580
quirogas merged 1 commit into
googleapis:mainfrom
jskeet:scripted-migrate-google-storagetransfer

Conversation

@jskeet

@jskeet jskeet commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

This PR migrates the google-storagetransfer package to use Librarian for code generation.

Highlights

  • Enabled Librarian generation for google-storagetransfer by removing skip_generate: true in librarian.yaml.
  • Added keep configuration for sample test utilities (samples/test/utils/bucket.js, samples/test/utils/index.js, samples/test/utils/sample.js, samples/test/utils/transfer.js) to preserve them during generation.
  • Removed OwlBot configuration (.OwlBot.yaml).
  • Updated .repo-metadata.json (pretty name, description, documentation links, and removed requires_billing).

Note on samples-test Task

The preserved utility files in samples/test/utils/ are intended for use by the sample test samples/test/quickstart.js.

These utility files are preserved for documentation purposes for library users, ensuring the sample tests remain complete and instructive.

Note that the samples-test task (npm run samples-test) currently fails to execute this test due to a wildcard mismatch in samples/package.json (which looks for test/*.test.js while the test file is quickstart.js).

User-facing Changes

None.

@jskeet jskeet requested a review from a team as a code owner June 11, 2026 10:14

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables code generation for the Google Storage Transfer service by removing the skip_generate flag in librarian.yaml. It also updates the repository metadata in .repo-metadata.json and deletes several unused sample helper and configuration files. There are no review comments, so no further feedback is provided.

@jskeet jskeet force-pushed the scripted-migrate-google-storagetransfer branch from 7f81adb to 7708483 Compare June 11, 2026 11:18
@jskeet jskeet marked this pull request as draft June 11, 2026 11:18
@jskeet jskeet force-pushed the scripted-migrate-google-storagetransfer branch from 7708483 to 947e1fb Compare June 11, 2026 14:44
@jskeet jskeet marked this pull request as ready for review June 11, 2026 14:44
@jskeet

jskeet commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@quirogas I've added the samples/test/utils files to the keep list.

@jskeet jskeet force-pushed the scripted-migrate-google-storagetransfer branch from 947e1fb to 220620c Compare June 11, 2026 14:49
Comment thread librarian.yaml
@quirogas quirogas merged commit f46fa75 into googleapis:main Jun 12, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants