Skip to content

test: remove testing on node 18 from matrix #8993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieljbruce merged 4 commits into from
Jul 29, 2026
Merged

test: remove testing on node 18 from matrix #8993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a9b0e5
test: remove testing on node 18 from matrix
danieljbruce Jul 28, 2026
e219b6b
Eliminate the zizmor checks
danieljbruce Jul 28, 2026
03a9f06
Update hashes with the latest version
danieljbruce Jul 29, 2026
5687d1b
pin exact versions for setup-node
danieljbruce Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/continuous.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [18, 22, 24, 26]
node: [22, 24, 26]
steps:
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6

@pearigee pearigee Jul 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we really going from v6 to v4? Or were these just mis-labled before?

We wouldn't want to downgrade our actions right? Do the newer versions just need to have their hashes corrected?

@danieljbruce danieljbruce Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were not mislabelled before, but I looked into this further and it seems the problem is we were using floating tags ie. v6 which were trying to match the sha in the yaml to the latest v6 sha and the mismatch was producing a zizmor error. Therefore, I pinned the versions after the # so that we don't see zizmor matches again.

- uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
with:
persist-credentials: false
- uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/presubmit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18, 22, 24, 26]
node-version: [22, 24, 26]
steps:
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
- uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
with:
fetch-depth: 300
persist-credentials: false
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
uses: actions/setup-node@249970729cb0ef3589644e2896645e5dc5ba9c38 # v6.5.0
with:
node-version: ${{ matrix.node-version }}
- uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4
Expand All @@ -32,12 +32,12 @@ jobs:
runs-on: ubuntu-latest
continue-on-error: true
steps:
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
- uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
with:
fetch-depth: 300
persist-credentials: false
- name: Use Node.js 24
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
uses: actions/setup-node@249970729cb0ef3589644e2896645e5dc5ba9c38 # v6.5.0
with:
node-version: 24
- run: npm install
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/windows-presubmit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ jobs:
runs-on: windows-latest
strategy:
matrix:
node-version: [18, 22, 24, 26]
node-version: [22, 24, 26]
steps:
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
- uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
with:
fetch-depth: 300
persist-credentials: false
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
uses: actions/setup-node@249970729cb0ef3589644e2896645e5dc5ba9c38 # v6.5.0
with:
node-version: ${{ matrix.node-version }}
- uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4
Expand Down
4 changes: 2 additions & 2 deletions ci/cloudbuild.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ options:
substitutions:
_BUILD_TYPE: "presubmit"
_TEST_TYPE: "system"
_NODE_VERSION: "18"
_NODE_VERSION: "22"
_REPO_OWNER: "googleapis"
_REPO_NAME: "google-cloud-node"

Expand Down Expand Up @@ -73,4 +73,4 @@ steps:
- 'IS_CORE=${_IS_CORE}'

images:
- 'gcr.io/${PROJECT_ID}/google-cloud-node-${_NODE_VERSION}'
- 'gcr.io/${PROJECT_ID}/google-cloud-node-${_NODE_VERSION}'
4 changes: 2 additions & 2 deletions ci/cloudbuild_with_gapic_showcase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ options:
substitutions:
_BUILD_TYPE: "presubmit"
_TEST_TYPE: "system"
_NODE_VERSION: "18"
_NODE_VERSION: "22"
_REPO_OWNER: "googleapis"
_REPO_NAME: "google-cloud-node"

Expand Down Expand Up @@ -73,7 +73,7 @@ steps:

- name: gcr.io/${PROJECT_ID}/google-cloud-node-${_NODE_VERSION}
id: "run-tests"
timeout: 32400s
timeout: 32400s
entrypoint: "bash"
args:
- '-c'
Expand Down
Loading