move Bigtable connection to match new directory structure#1024
Merged
dwsupplee merged 1 commit intogoogleapis:bigtablefrom Apr 20, 2018
Merged
Conversation
googlebot
added
the
cla: yes
mohitq
pushed a commit
to mohitq/google-cloud-php
that referenced
this pull request
May 23, 2018
dwsupplee
pushed a commit
that referenced
this pull request
Jun 4, 2018
* Connection interface * Connection interface * Update Connection * Update Connection * Update connection interface * Update connection interface * Updating camelCase names * Asterisks vertically aligned * move Bigtable connection to match new directory structure (#1024) * ConnectionInterface grpc * Updating camelCase names * Asterisks vertically aligned * pulled in change * Implemented Interface methods * Update Grpc * Merge from src/Bigtable to Bigtable/src * Connection Interface * removed file from old directory * Bigtable Client * Remove BIgtableClient * Instance Update * change client object * Add labels args and remove name for instance * Update CreateInstance * Created stub for functions that are not implemented and threw exception. * Unit test * Update camel case arguments * Revert "Update camel case arguments" This reverts commit c1da800. * Update Changes
sduskis
pushed a commit
that referenced
this pull request
Jul 9, 2018
sduskis
pushed a commit
that referenced
this pull request
Jul 9, 2018
* Connection interface * Connection interface * Update Connection * Update Connection * Update connection interface * Update connection interface * Updating camelCase names * Asterisks vertically aligned * move Bigtable connection to match new directory structure (#1024) * ConnectionInterface grpc * Updating camelCase names * Asterisks vertically aligned * pulled in change * Implemented Interface methods * Update Grpc * Merge from src/Bigtable to Bigtable/src * Connection Interface * removed file from old directory * Bigtable Client * Remove BIgtableClient * Instance Update * change client object * Add labels args and remove name for instance * Update CreateInstance * Created stub for functions that are not implemented and threw exception. * Unit test * Update camel case arguments * Revert "Update camel case arguments" This reverts commit c1da800. * Update Changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @mohitq
I should have caught this before we merged the last PR, my bad. We have a new directory structure we need to adhere to which would put the Bigtable code in
Bigtable/srcinstead ofsrc/Bigtable(it helps to make managing our release process a bit easier).We'll get this merged in once CI passes, if you can please make sure to use this revision for future PRs that would be great :).