Skip to content

Add getServiceAccount to the BigQueryClient#1167

Merged
dwsupplee merged 6 commits intogoogleapis:masterfrom
tmatsuo:bigquery-customer-supplied-key
Jul 10, 2018
Merged

Add getServiceAccount to the BigQueryClient#1167
dwsupplee merged 6 commits intogoogleapis:masterfrom
tmatsuo:bigquery-customer-supplied-key

Conversation

@tmatsuo
Copy link
Copy Markdown
Contributor

@tmatsuo tmatsuo commented Jul 10, 2018

@tmatsuo tmatsuo added the api: bigquery Issues related to the BigQuery API. label Jul 10, 2018
@tmatsuo tmatsuo requested a review from dwsupplee July 10, 2018 01:28
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2018
dwsupplee
dwsupplee reviewed Jul 10, 2018
View reviewed changes
Comment thread BigQuery/src/BigQueryClient.php Outdated
* Configuration options.
*
* @type string $projectId The project ID from the Google Developer's
* @type string $projectId The project ID from the Google Developer's

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread BigQuery/src/Connection/Rest.php Outdated
*/
public function getServiceAccount(array $args = [])
{
return $this->send("projects", "getServiceAccount", $args);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread BigQuery/src/BigQueryClient.php Outdated
*/
public function getServiceAccount()
{
$resp = $this->connection->getServiceAccount(

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread BigQuery/src/BigQueryClient.php Outdated
* ```
* @return string
*/
public function getServiceAccount()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread BigQuery/src/BigQueryClient.php
*
* Example:
* ```
* $serviceAccount = $bigQuery->getServiceAccount();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dwsupplee
dwsupplee approved these changes Jul 10, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits, otherwise LGTM

Comment thread BigQuery/src/BigQueryClient.php Outdated
* ```
* $serviceAccount = $bigQuery->getServiceAccount();
* ```
* @param array $options [optional] Please see the

This comment was marked as spam.

Sign in to view

Comment thread BigQuery/src/BigQueryClient.php
* Example:
* ```
* $serviceAccount = $bigQuery->getServiceAccount();
* ```

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread BigQuery/tests/Snippet/BigQueryClientTest.php Outdated
$expectedEmail = uniqid() . '@bigquery-encryption.iam.gserviceaccount.com';
$snippet = $this->snippetFromMethod(BigQueryClient::class, 'getServiceAccount');
$snippet->addLocal('bigQuery', $this->client);
$this->connection->getServiceAccount(['projectId' => $this::PROJECT_ID])

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tmatsuo
tmatsuo commented Jul 10, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwsupplee Thanks! Comments addressed, PTAL

Comment thread BigQuery/src/BigQueryClient.php
*
* Example:
* ```
* $serviceAccount = $bigQuery->getServiceAccount();

This comment was marked as spam.

Sign in to view

Comment thread BigQuery/src/BigQueryClient.php
* Example:
* ```
* $serviceAccount = $bigQuery->getServiceAccount();
* ```

This comment was marked as spam.

Sign in to view

@dwsupplee dwsupplee merged commit 1234daf into googleapis:master Jul 10, 2018
@tmatsuo tmatsuo mentioned this pull request Jul 10, 2018
Merged
@dwsupplee dwsupplee mentioned this pull request Jul 13, 2018
Merged
sduskis pushed a commit that referenced this pull request Jul 23, 2018
@dwsupplee @sduskis
Update Bigtable branch with latest from master (#1190)
c2f4028 
* Add isRacy() to SafeSearch (#1166)

The SafeSearch class included `is` functions for each SafeSearch feature (adult, spoof, medical, violence), but was missing Racy. This Pull Request adds `isRacy()` to the SafeSearch class.

* Exclude component vendor folder from snippet coverage (#1168)

cc @tmatsuo

* Allow context to handle Throwable interface (#1164)

* Add getServiceAccount to the BigQueryClient (#1167)

* Add getServiceAccount to the BigQueryClient

See:
https://cloud.google.com/bigquery/docs/reference/rest/v2/projects/getServiceAccount

* Added $options to getServiceAccount and fixed the indent

* Use single quote

* Add snippet test

* Comment update, use self instead of $this

* Comment update

* Prepare v0.71.0 (#1169)

* Prepare v0.71.0

* patch release for Logging

* Correct version for Logging

* [Kms] Regenerate with the new gapic config (#1165)

* Update for the new gapic configuration

* Docs update for the new and nicer namespace

* Removed the files with the old namespace

* Use the new namespace in the code sample

Add back the deprecated files

* Changed the wording for the deprecation warning

* Fix firestore queries (#1161)

* Bump gax to 0.35 (#1170)

* Add an interactive release builder. (#1160)

* Add an interactive release builder.

* Create build directory if it doesn't exist

* Add getServiceAccount method to StorageClient (#1173)

* Re-generate library using Tasks/synth.py (#1174)

* Re-generate library using Tasks/synth.py

* Use new namespace in user visible area, tweak the deprecation wording

* Add support for Numeric type (#1172)

* Add support for Numeric type

* Added a cast in Numeric's constructor, added system tests

* Allow '123.' and '.123', update tests

* [Breaking Change] Add support for Document Snapshots in Firestore Query Cursors (#1162)

cc @schmidt-sebastian

Extracted from #923 and updated to address pull request comments.

Breaking change is the standardization in Query of using `InvalidArgumentException`, replacing various throws of `BadMethodCallException`.

Closes #851.

* Fix Storage Requesterpays system tests (#1180)

The requester pays system tests have been broken for some time. This change fixes them.

* Bandaid for protobuf 4761 (#1176)

* Temporary workaround for protobuf extension issue

protocolbuffers/protobuf#4761

* Bump gax to 0.36

* Configure comparators for the unit test

* Revert back to normal TestCase

* Install protobuf extension in the PHP 7.2 test runner

* Revert to TestCase

* Prepare v0.72.0 (#1181)

* Added a document for the time filter on BigQueryClient->jobs() (#1183)

* Narrowed the time filter in the system test (#1185)

* Re-generate library using BigQueryDataTransfer/synth.py (#1184)

* Re-generate library using BigQueryDataTransfer/synth.py

* Tweak the wording on the deprecation warning

Also use the new namespace in the sample code

* pin auth version until we have a way to silence warnings (#1189)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dwsupplee dwsupplee dwsupplee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmatsuo @dwsupplee @googlebot