Run PHPCS on tests#1192
Merged
jdpedrie merged 2 commits intogoogleapis:masterfrom Jul 26, 2018
jdpedrie:phpcs-tests
Merged
Conversation
googlebot
added
the
cla: yes
tmatsuo
reviewed
Jul 26, 2018
| @@ -0,0 +1,56 @@ | |||
| <?php | |||
| /** | |||
| * Copyright 2018 Google Inc. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -0,0 +1,30 @@ | |||
| <?php | |||
| /** | |||
| * Copyright 2018 Google Inc. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dwsupplee
approved these changes
Jul 26, 2018
Contributor
dwsupplee
left a comment
dwsupplee
left a comment
There was a problem hiding this comment.
Outside of Takashi's note, LGTM
Merged
jdpedrie
added a commit
that referenced
this pull request
Aug 8, 2018
## Google Cloud PHP v0.73.0 ### google/cloud-bigquery v1.4.1 * Added documentation for BigQuery job time filter. (#1183) * Updated tests to conform to linting requirements. (#1192) ### google/cloud-bigquerydatatransfer v0.7.0 * Updated BigQueryDataTransfer generated client. (#1184) ### google/cloud-core v1.22.0 * Updated Symfony Lock Adapter to provide better exception messaging and context. (#1204) * Added support for custom headers on resumable uploaders. (#1111) * Updated tests to conform to linting requirements. (#1192) ### google/cloud-datastore v1.5.5 * Updated tests to conform to linting requirements. (#1192) ### google/cloud-debugger v0.12.3 * Updated tests to conform to linting requirements. (#1192) ### google/cloud-error-reporting v0.11.3 * Updated tests to conform to linting requirements. (#1192) ### google/cloud-firestore v0.12.1 * Updated tests to conform to linting requirements. (#1192) ### google/cloud-language v0.15.3 * Updated tests to conform to linting requirements. (#1192) ### google/cloud-logging v1.12.6 * Updated tests to conform to linting requirements. (#1192) ### google/cloud-pubsub v1.4.2 * Updated tests to conform to linting requirements. (#1192) ### google/cloud-spanner v1.6.3 * Fixed a bug which prevented field values from being set to `null`. (#1201) * Updated tests to conform to linting requirements. (#1192) ### google/cloud-speech v0.16.0 * **BREAKING CHANGE** Removed deprecated v1beta1 client for Cloud Speech and update generated clients. (#1196) * Updated tests to conform to linting requirements. (#1192) ### google/cloud-storage v1.7.0 * Improve Storage Signed URL support. Added support for CORS headers and improved validation of inputs. (#1111) * Updated tests to conform to linting requirements. (#1192) ### google/cloud-text-to-speech v0.1.2 * Updated tests to conform to linting requirements. (#1192) ### google/cloud-trace v0.10.3 * Updated tests to conform to linting requirements. (#1192) ### google/cloud-translate v1.2.4 * Updated tests to conform to linting requirements. (#1192) ### google/cloud-vision v0.15.2 * Updated tests to conform to linting requirements. (#1192)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the PHPCS configuration to enforce coding standards on all test files (unit, snippet and system tests). It continues to exclude generated code.
It also includes a sweep of test cleanup to conform to standards and modernizes some very old test code. This change shouldn't include changes to actual client code.