Skip to content

Conversation

@dwsupplee
Copy link
Contributor

Closes: #1741

We can prevent errors regarding the lack of the STDERR constant outside of CLI context when creating a resource manually through fopen('php://stderr', 'w').

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 10, 2019
@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #1818 into master will not change coverage.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1818   +/-   ##
=========================================
  Coverage     91.53%   91.53%           
+ Complexity     4371     4368    -3     
=========================================
  Files           304      304           
  Lines         12914    12914           
=========================================
  Hits          11821    11821           
  Misses         1093     1093
Impacted Files Coverage Δ Complexity Δ
Core/src/Batch/BatchTrait.php 88.33% <75%> (ø) 12 <0> (-3) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be5a2ed...eee91f1. Read the comment docs.

@dwsupplee dwsupplee merged commit 6e22867 into googleapis:master Apr 10, 2019
@jdpedrie jdpedrie mentioned this pull request Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: core cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants