Add support for excludeFromIndexes in embedded entities#754
Merged
jdpedrie merged 2 commits intogoogleapis:masterfrom Dec 11, 2017
jdpedrie:datastore-embedded-entities-ignore-indexes
Merged
Add support for excludeFromIndexes in embedded entities#754jdpedrie merged 2 commits intogoogleapis:masterfrom jdpedrie:datastore-embedded-entities-ignore-indexes
jdpedrie merged 2 commits intogoogleapis:masterfrom
jdpedrie:datastore-embedded-entities-ignore-indexes
Conversation
dwsupplee
suggested changes
Dec 11, 2017
| */ | ||
| public function commit(array $args) | ||
| { | ||
| // print_r($args);exit; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dwsupplee
approved these changes
Dec 11, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @maksimru
This change adds support for excluding properties of embedded entities from datastore indexes.
We've added a todo item for the next major version to improve on this, but for the time being this is the best option to avoid a backwards-compatibility break.