Return latest write result#777
Merged
jdpedrie merged 2 commits intogoogleapis:masterfrom Dec 11, 2017
jdpedrie:firestore-write-result
Merged
Return latest write result#777jdpedrie merged 2 commits intogoogleapis:masterfrom jdpedrie:firestore-write-result
jdpedrie merged 2 commits intogoogleapis:masterfrom
jdpedrie:firestore-write-result
Conversation
googlebot
added
the
cla: yes
dwsupplee
suggested changes
Dec 11, 2017
Contributor
dwsupplee
left a comment
dwsupplee
left a comment
There was a problem hiding this comment.
The docblock for writeResult should be updated, otherwise LGTM
Contributor
Author
|
thanks @dwsupplee. done. |
dwsupplee
approved these changes
Dec 11, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies the return value of mutation calls on DocumentReference. If multiple write results are found, the latest is now returned rather than the first. This is to better conform with the Firestore implementation guide, which states as follows:
This change is not breaking.